Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wicked from 1.4.0 to 2.0.0 #2978

Merged
merged 5 commits into from
Feb 7, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 26, 2022

Bumps wicked from 1.4.0 to 2.0.0.

Changelog

Sourced from wicked's changelog.

2.0.0

  • Return 422 (:unprocessable_entity) when form submissions fails. Turbo requires an HTTP Status code between 400-499 or 500-599 when a FormSubmission request fails. This pull request makes wicked compatible with Turbo Drive (zombocom/wicked#294)
  • Pass the provided step when raising InvalidStepError errors (zombocom/wicked#284)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Sep 26, 2022
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 4 times, most recently from f14e103 to 47ab638 Compare November 1, 2022 20:53
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 6 times, most recently from 3c16c49 to a71f804 Compare November 15, 2022 18:51
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 4 times, most recently from b6c922e to 557b6da Compare November 16, 2022 00:35
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch from 557b6da to 11a0878 Compare November 30, 2022 17:58
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 4 times, most recently from b39cc32 to 28c0cb1 Compare December 14, 2022 22:42
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 3 times, most recently from c789858 to 2489963 Compare January 24, 2023 20:33
@pgwillia
Copy link
Member

Failure:
Admin::Theses::DraftControllerTest#test_should_not_be_able_to_update_a_draft_thesis_when_saving_upload_files_form_that_has_no_file_attachments [/home/runner/work/jupiter/jupiter/test/controllers/admin/theses/draft_controller_test.rb:137]:
Expected response to be a <2XX: success>, but was a <422: Unprocessable Entity>

@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch from 2489963 to a04bbf7 Compare January 27, 2023 22:44
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 12 times, most recently from 1b3e006 to f003eb2 Compare February 4, 2023 02:19
Bumps [wicked](https://github.com/schneems/wicked) from 1.4.0 to 2.0.0.
- [Release notes](https://github.com/schneems/wicked/releases)
- [Changelog](https://github.com/zombocom/wicked/blob/main/CHANGELOG.md)
- [Commits](zombocom/wicked@v1.4.0...v2.0.0)

---
updated-dependencies:
- dependency-name: wicked
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch 9 times, most recently from 1e92551 to e8f2831 Compare February 6, 2023 23:45
Bumps [wicked](https://github.com/schneems/wicked) from 1.4.0 to 2.0.0.
- [Release notes](https://github.com/schneems/wicked/releases)
- [Changelog](https://github.com/zombocom/wicked/blob/main/CHANGELOG.md)
- [Commits](zombocom/wicked@v1.4.0...v2.0.0)

---
updated-dependencies:
- dependency-name: wicked
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/master/wicked-2.0.0 branch from e8f2831 to b21e16a Compare February 6, 2023 23:52
Copy link
Contributor

@ConnorSheremeta ConnorSheremeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the wizard and it functioned as expected. New status code returned didn't affect functionality but it broke tests... fixed.

@ConnorSheremeta ConnorSheremeta merged commit a237696 into master Feb 7, 2023
@ConnorSheremeta ConnorSheremeta deleted the dependabot/bundler/master/wicked-2.0.0 branch February 7, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants