Remove eol Ruby 2.6 #2878
Merged
Remove eol Ruby 2.6 #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
requested review from
ConnorSheremeta,
jefferya and
lagoan
as code owners
pgwillia
force-pushed
the
update_ci_ruby_2.7
branch
from
cb8494f
to
123cdb1
Compare
|
Removed 2.6 from required status checks
|
pgwillia
force-pushed
the
update_ci_ruby_2.7
branch
from
06c32bb
to
294354f
Compare
pgwillia
force-pushed
the
update_ci_ruby_2.7
branch
from
294354f
to
abdeca6
Compare
We're currently running 2.7.6 in production (introduced April 2022). Some of our dependencies have removed Ruby 2.6 from their support now too so CI fails (eg. #2873).
Use ENV.fetch('RAILS_ENV') or ENV.fetch('RAILS_ENV', nil) instead of ENV['RAILS_ENV']. (https://rubystyle.guide/#hash-fetch-defaults)
Use filter_map instead.
This cop identifies places where map { … }.compact can be replaced by filter_map.
This cop’s autocorrection is unsafe because map { … }.compact that is not compatible with filter_map.
`warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call` In Ruby 2.7, the way it handles the positional arguments and keyword arguments is changed, aiming to provide a smooth transition to Ruby 3. If you were passing a Hash as a keyword argument, now you'd need to update your code to use the double splat `**` operator. https://bloggie.io/@kinopyo/how-to-fix-ruby-2-7-warning-using-the-last-argument-as-keyword-parameters-is-deprecated
pgwillia
force-pushed
the
update_ci_ruby_2.7
branch
from
abdeca6
to
44d9ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We're currently running 2.7.6 in production (introduced April 2022).
Some of our dependencies have removed Ruby 2.6 from their support now too so CI fails (eg. #2873).
What's New
Update mentions of Ruby 2.6 to 2.7 in readme, ci, gemfile, asdf tool-versions and docker.