-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rubocop-rails from 2.12.4 to 2.13.0 #2683
Merged
pgwillia
merged 6 commits into
master
from
dependabot/bundler/master/rubocop-rails-2.13.0
Jan 5, 2022
Merged
Bump rubocop-rails from 2.12.4 to 2.13.0 #2683
pgwillia
merged 6 commits into
master
from
dependabot/bundler/master/rubocop-rails-2.13.0
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
requested review from
ConnorSheremeta,
lagoan,
murny and
pgwillia
as code owners
December 27, 2021 17:21
dependabot
bot
force-pushed
the
dependabot/bundler/master/rubocop-rails-2.13.0
branch
from
January 4, 2022 16:19
882f4b8
to
559ac5f
Compare
Offenses:
|
dependabot
bot
force-pushed
the
dependabot/bundler/master/rubocop-rails-2.13.0
branch
7 times, most recently
from
January 4, 2022 21:37
0d9398f
to
2a457dd
Compare
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.12.4 to 2.13.0. - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.12.4...v2.13.0) --- updated-dependencies: - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/master/rubocop-rails-2.13.0
branch
from
January 4, 2022 22:01
2a457dd
to
4701071
Compare
Remove explicit presence validation for user.
Use compact_blank instead. https://devdocs.io/rails~6.1/enumerable#method-i-compact_blank
Do not add or subtract duration. (https://rails.rubystyle.guide#duration-arithmetic)
Bump rubocop-rails to 2.13.0 and fix cop violations
Remove explicit presence validation for user.
pgwillia
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop-rails from 2.12.4 to 2.13.0.
Release notes
Sourced from rubocop-rails's releases.
Changelog
Sourced from rubocop-rails's changelog.
Commits
3679845
Cut 2.13.03cae05d
Update Changelog7dabfc7
MarkRails/CompactBlank
as unsafea80ac3b
Merge pull request #598 from koic/add_new_rails_compact_blank_cop37e882f
Suppress a RuboCop offensec7f39c4
[Fix #562] Add newRails/CompactBlank
cop5b230e5
Merge pull request #594 from pirj/introduce-redundant-presence-validation-on-...301c7d4
[Fix #587] Add Rails/RedundantPresenceValidationOnBelongsTo cop584deee
Restore a pull request template entry5eb31b4
Merge pull request #595 from pirj/introduce-gemfile-localDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)