Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.12.4 to 2.13.0 #2683

Merged
merged 6 commits into from
Jan 5, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 27, 2021

Bumps rubocop-rails from 2.12.4 to 2.13.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.13.0

New features

Changes

  • #591: Add change_column check to Rails/ReversibleMigration. (@​mattmccormick)
  • Add remove_reference check to Rails/ReversibleMigration. (@​mattmccormick)
  • #576: Mark Rails/TimeZone as unsafe auto-correction from unsafe. (@​koic)
  • #582: Unmark AutoCorrect: false from Rails/RelativeDateConstant. (@​koic)
  • #580: Unmark AutoCorrect: false from Rails/UniqBeforePluck. (@​koic)
Changelog

Sourced from rubocop-rails's changelog.

2.13.0 (2021-12-25)

New features

Changes

  • #591: Add change_column check to Rails/ReversibleMigration. ([@​mattmccormick][])
  • Add remove_reference check to Rails/ReversibleMigration. ([@​mattmccormick][])
  • #576: Mark Rails/TimeZone as unsafe auto-correction from unsafe. ([@​koic][])
  • #582: Unmark AutoCorrect: false from Rails/RelativeDateConstant. ([@​koic][])
  • #580: Unmark AutoCorrect: false from Rails/UniqBeforePluck. ([@​koic][])
Commits
  • 3679845 Cut 2.13.0
  • 3cae05d Update Changelog
  • 7dabfc7 Mark Rails/CompactBlank as unsafe
  • a80ac3b Merge pull request #598 from koic/add_new_rails_compact_blank_cop
  • 37e882f Suppress a RuboCop offense
  • c7f39c4 [Fix #562] Add new Rails/CompactBlank cop
  • 5b230e5 Merge pull request #594 from pirj/introduce-redundant-presence-validation-on-...
  • 301c7d4 [Fix #587] Add Rails/RedundantPresenceValidationOnBelongsTo cop
  • 584deee Restore a pull request template entry
  • 5eb31b4 Merge pull request #595 from pirj/introduce-gemfile-local
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Dec 27, 2021
@dependabot dependabot bot force-pushed the dependabot/bundler/master/rubocop-rails-2.13.0 branch from 882f4b8 to 559ac5f Compare January 4, 2022 16:19
@pgwillia
Copy link
Member

pgwillia commented Jan 4, 2022

Offenses:

  • app/models/announcement.rb:5:20: C: [Correctable] Rails/RedundantPresenceValidationOnBelongsTo: Remove explicit presence validation for user.
    validates :user, presence: true
    ^^^^^^^^^^^^^^
  • app/models/collection.rb:11:28: C: [Correctable] Rails/RedundantPresenceValidationOnBelongsTo: Remove explicit presence validation for community_id.
    validates :community_id, presence: true
    ^^^^^^^^^^^^^^
  • app/models/draft_item.rb:327:25: C: [Correctable] Rails/CompactBlank: Use compact_blank instead.
    self[key] = value.reject(&:blank?)
    ^^^^^^^^^^^^^^^^
  • test/integration/oaisys_list_identifiers_test.rb:220:26: C: [Correctable] Rails/DurationArithmetic: Do not add or subtract duration. (https://rails.rubystyle.guide#duration-arithmetic)
    six_days_from_now = (Time.current + 6.days).strftime('%Y-%m-%d')
    ^^^^^^^^^^^^^^^^^^^^^
  • test/integration/oaisys_list_identifiers_test.rb:228:26: C: [Correctable] Rails/DurationArithmetic: Do not add or subtract duration. (https://rails.rubystyle.guide#duration-arithmetic)
    six_days_from_now = (Time.current + 6.days).strftime('%Y-%m-%d')
    ^^^^^^^^^^^^^^^^^^^^^
  • test/integration/oaisys_list_identifiers_test.rb:237:26: C: [Correctable] Rails/DurationArithmetic: Do not add or subtract duration. (https://rails.rubystyle.guide#duration-arithmetic)
    six_days_from_now = (Time.current + 6.days).utc.xmlschema
    ^^^^^^^^^^^^^^^^^^^^^
  • test/integration/oaisys_list_identifiers_test.rb:245:26: C: [Correctable] Rails/DurationArithmetic: Do not add or subtract duration. (https://rails.rubystyle.guide#duration-arithmetic)
    six_days_from_now = (Time.current + 6.days).utc.xmlschema
    ^^^^^^^^^^^^^^^^^^^^^

@dependabot dependabot bot force-pushed the dependabot/bundler/master/rubocop-rails-2.13.0 branch 7 times, most recently from 0d9398f to 2a457dd Compare January 4, 2022 21:37
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.12.4 to 2.13.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.12.4...v2.13.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/master/rubocop-rails-2.13.0 branch from 2a457dd to 4701071 Compare January 4, 2022 22:01
Remove explicit presence validation for user.
Bump rubocop-rails to 2.13.0 and fix cop violations
Remove explicit presence validation for user.
@pgwillia pgwillia merged commit 8635170 into master Jan 5, 2022
@pgwillia pgwillia deleted the dependabot/bundler/master/rubocop-rails-2.13.0 branch January 5, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant