Add healthcheck page for asserting health of application #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murny
commented
Dec 13, 2021
| @@ -2,4 +2,10 @@ class StaticPagesController < ApplicationController | |||
|
|
|||
| skip_after_action :verify_authorized | |||
|
|
|||
| def about; end | |||
There was a problem hiding this comment.
We should be explicit about our actions in our controllers? Not sure why we removed these. Adding them back!
Generated by 🚫 Danger |
murny
force-pushed
the
add-healthcheck
branch
from
68e0216 to
64971a3
Compare
murny
requested review from
ConnorSheremeta,
lagoan and
pgwillia
as code owners
murny
commented
Jan 21, 2022
| Sidekiq.configure_server do |config| | ||
| config.redis = { url: Rails.application.secrets.redis_url } | ||
|
|
||
| schedule_file = 'config/schedule.yml' | ||
| Sidekiq::Cron::Job.load_from_hash YAML.load_file(schedule_file) if File.exist?(schedule_file) | ||
|
|
There was a problem hiding this comment.
This is basically extracted from official sidekiq docs: https://github.com/mperham/sidekiq/wiki/Kubernetes#health-checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cloud.google.com/blog/products/containers-kubernetes/kubernetes-best-practices-setting-up-health-checks-with-readiness-and-liveness-probes
Add readiness healthcheck for jupiter and sidekiq processes. This will be very useful for Operations team or for readiness checking within Kubernetes