Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.14.0 to 1.15.0 #2343

Merged
merged 2 commits into from
May 20, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 17, 2021

Bumps rubocop from 1.14.0 to 1.15.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.15

New features

Bug fixes

  • #9749: Fix autocorrection for Layout/LineLength to not move the first argument of an unparenthesized send node to the next line, which changes behaviour. (@​dvandersluis)
  • #9799: Fix invalid line splitting by Layout/LineLength for send nodes with heredoc arguments. (@​dvandersluis)
  • #9773: Fix Style/EmptyLiteral to not register offenses for String.new when Style/FrozenStringLiteral is enabled. (@​dvandersluis)
  • #9771: Change AllowDSLWriters to true by default for Style/TrivialAccessors. (@​koic)
  • #9777: Fix an incorrect auto-correct for Style/RedundantBegin when using multi-line if in begin block. (@​koic)
  • #9791: Fix a false negative for Layout/IndentationWidth when using ensure in do ... end block. (@​koic)
  • #9766: Fix a clobbering error for Style/ClassAndModuleChildren cop with compact style. (@​tejasbubane)
  • #9767: Fix Style/ClassAndModuleChildren cop to preserve comments. (@​tejasbubane)
  • #9792: Fix false positive for Lint/Void cop with ranges. (@​tejasbubane)

Changes

  • #9770: Update Lint/EmptyBlock to handle procs the same way as lambdas. (@​dvandersluis)
  • #9776: Update Style/NilLambda to handle procs as well. (@​dvandersluis)
  • #9744: The parallel flag will now be automatically ignored when combined with --cache false. Previously, an error was raised and execution stopped. (@​rrosenblum)
Changelog

Sourced from rubocop's changelog.

1.15.0 (2021-05-17)

New features

Bug fixes

  • #9749: Fix autocorrection for Layout/LineLength to not move the first argument of an unparenthesized send node to the next line, which changes behaviour. ([@​dvandersluis][])
  • #9799: Fix invalid line splitting by Layout/LineLength for send nodes with heredoc arguments. ([@​dvandersluis][])
  • #9773: Fix Style/EmptyLiteral to not register offenses for String.new when Style/FrozenStringLiteral is enabled. ([@​dvandersluis][])
  • #9771: Change AllowDSLWriters to true by default for Style/TrivialAccessors. ([@​koic][])
  • #9777: Fix an incorrect auto-correct for Style/RedundantBegin when using multi-line if in begin block. ([@​koic][])
  • #9791: Fix a false negative for Layout/IndentationWidth when using ensure in do ... end block. ([@​koic][])
  • #9766: Fix a clobbering error for Style/ClassAndModuleChildren cop with compact style. ([@​tejasbubane][])
  • #9767: Fix Style/ClassAndModuleChildren cop to preserve comments. ([@​tejasbubane][])
  • #9792: Fix false positive for Lint/Void cop with ranges. ([@​tejasbubane][])

Changes

  • #9770: Update Lint/EmptyBlock to handle procs the same way as lambdas. ([@​dvandersluis][])
  • #9776: Update Style/NilLambda to handle procs as well. ([@​dvandersluis][])
  • #9744: The parallel flag will now be automatically ignored when combined with --cache false. Previously, an error was raised and execution stopped. ([@​rrosenblum][])
Commits
  • 9c9b891 Cut 1.15
  • b92be6a Update Changelog
  • eecc7c8 Tweak some wording
  • b3e567c [Fix #9767] Fix Style/ClassAndModuleChildren cop to preserve comments
  • dca0471 [Change #9744] Auto disable parallel when combined with cache false
  • 40d0970 [Fix #9792] Fix false positive for Lint/Void cop
  • 4f13546 Merge pull request #9801 from dvandersluis/issue/9749
  • fcde5d7 Merge pull request #9800 from dvandersluis/issue/9799
  • 60834d4 [Fix #9749] Fix autocorrection for Layout/LineLength to not move the first ...
  • 1d81c00 [Fix #9799] Fix invalid line splitting by Layout/LineLength for send node...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels May 17, 2021
pgwillia
pgwillia previously approved these changes May 20, 2021
@pgwillia
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 20, 2021

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@pgwillia
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/bundler/integration/rubocop-1.15.0 branch from ad15f76 to aa467fc Compare May 20, 2021 16:37
Rubocop 1.15.0 changed the default of `AllowDSLWriters` to true for
Style/TrivialAccessors so this disable isn't needed anymore.
@pgwillia pgwillia merged commit 9a96b04 into integration May 20, 2021
@dependabot dependabot bot deleted the dependabot/bundler/integration/rubocop-1.15.0 branch May 20, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants