Test fixture record name refactor #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a change in the community and collections that were being used for the fixtures, this caused the aip files to show different community and collection uuids. This change gets the community and collection uuid from the fixtures instead of hard coding the values in the output file.
ConnorSheremeta
requested review from
lagoan,
mbarnett,
murny and
pgwillia
as code owners
Generated by 🚫 Danger |
pgwillia
previously approved these changes
May 7, 2021
pgwillia
approved these changes
May 11, 2021
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found that having duplicate fixture record names caused problems. All fixture names have been modified to ensure their uniqueness.