Various fixes from lighthouse suggestions #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorSheremeta
requested review from
lagoan,
mbarnett,
murny and
pgwillia
as code owners
ConnorSheremeta
force-pushed
the
cds/lighthouse-fixes
branch
from
5c50c81
to
031a7e4
Compare
murny
reviewed
Mar 29, 2021
app/javascript/styles/jupiter.scss
Outdated
| @@ -25,6 +25,14 @@ body { | |||
| } | |||
| } | |||
|
|
|||
| // Increase footer link spacing on mobile to improve usability and seo. | |||
There was a problem hiding this comment.
You can probably do this all within bootstrap via these utilities classes: https://getbootstrap.com/docs/4.6/utilities/spacing/
So if you want top/bottom padding of around 3px for small devices you can just add the following class to these items:
py-sm-1
(it will actually be 4px instead of 3px, but doubt that makes any difference)
There was a problem hiding this comment.
Neat, those bootstrap classes are very versatile!
Generated by 🚫 Danger |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now pre-loading main FA fonts, increased link spacing on mobile, and ordered the header tags in a more accessible way.