Update Architecture Diagram #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnett
requested review from
ConnorSheremeta,
lagoan,
murny and
pgwillia
as code owners
murny
reviewed
Feb 2, 2021
app/helpers/page_layout_helper.rb
Outdated
| @@ -49,8 +49,6 @@ def thumbnail_path(logo, args = { resize_to_limit: [100, 100], auto_orient: true | |||
|
|
|||
| Rails.application.routes.url_helpers.rails_representation_path(logo.representation(args).processed) | |||
| rescue StandardError => e | |||
There was a problem hiding this comment.
Rubocop crying about unused variable e here
murny
reviewed
Feb 2, 2021
| @@ -8,6 +8,8 @@ and releases in Jupiter project adheres to [Semantic Versioning](http://semver.o | |||
|
|
|||
| – Remove entirely unnecessary config file. | |||
| – Turn off reporting things like "this excel spreadsheet isn't thumbnailable" as warnings to Rollbar | |||
| – Completely disable logging of warnings around the "excel spreadsheet" issue | |||
There was a problem hiding this comment.
Something is weird here 🤔 , it deleted a big chunk of the unreleased logs as shown in master:
## [Unreleased]
– Remove entirely unnecessary config file.
– Turn off reporting things like "this excel spreadsheet isn't thumbnailable" as warnings to Rollbar
– Completely disable logging of warnings around the "excel spreadsheet" issue
### Added
- Initialize disabled ReadOnlyMode [#2100](https://github.com/ualbertalib/jupiter/issues/2100)
### Removed
– Remove entirely unnecessary config file. [PR#2044](https://github.com/ualbertalib/jupiter/pull/2044)
### Changed
- Added DOI reset feature for admins [#1739](https://github.com/ualbertalib/jupiter/issues/1739)
– Turn off reporting things like "this excel spreadsheet isn't thumbnailable" as warnings to Rollbar [PR#2046](https://github.com/ualbertalib/jupiter/pull/2046)
- migration to fix concatenated subjects (part 2) [#1449](https://github.com/ualbertalib/jupiter/issues/1449)
- Catch and log embargo expiry job save errors [#1989](https://github.com/ualbertalib/jupiter/issues/1989)
- Don't send failures to SessionController in development environment [PR#2121](https://github.com/ualbertalib/jupiter/pull/2121)
### Fixed
- bump rubocop and fix cop violations [PR#2072](https://github.com/ualbertalib/jupiter/pull/2072)
- bump omniauth-rails_csrf_protection gem for omniauth compatibility [PR#2096](https://github.com/ualbertalib/jupiter/pull/2096)
- bump rdf-n3 and fix isomorphic_with? regression [PR#2070](https://github.com/ualbertalib/jupiter/pull/2070)
- bump rubocop and fix more cop violations [PR#2132](https://github.com/ualbertalib/jupiter/pull/2132)
## [2.0.2] - 2020-12-17
There was a problem hiding this comment.
Should be fixed now?
Generated by 🚫 Danger |
murny
approved these changes
Feb 2, 2021
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We've had a lot of big changes under the hood over the last year, so let's update the diagrams to reflect that!
What's New