Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.8.1 to 1.9.1 #2132

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 1, 2021

Bumps rubocop from 1.8.1 to 1.9.1.

Release notes

Sourced from rubocop's releases.

RuboCop 1.9.1

New features

  • #9459: Add AllowedMethods option to Style/IfWithBooleanLiteralBranches and set nonzero? as default value. (@koic)

Bug fixes

  • #9431: Fix an error for Style/DisableCopsWithinSourceCodeDirective when using leading source comment. (@koic)
  • #9444: Fix error on colorization for offenses with Severity: info. (@tejasbubane)
  • #9448: Fix an error for Style/SoleNestedConditional when using nested unless modifier with a single expression condition. (@koic)
  • #9449: Fix an error for Style/NilComparison when using x == nil as a guard condition'. (@koic)
  • #9440: Fix Lint/SymbolConversion for implicit to_sym without a receiver. (@dvandersluis)
  • #9453: Fix infinite loop error for Layout/FirstParameterIndentation when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. (@koic)
  • #9466: Don't correct Style/SingleLineMethods using endless methods if the target ruby is < 3.0. (@dvandersluis)
  • #9455: Fix a false positive for Lint/SymbolConversion when hash keys that contain ":". (@koic)
  • #9454: Fix an incorrect auto-correct for Style/IfWithBooleanLiteralBranches when using elsif do_something? with boolean literal branches. (@koic)
  • #9438: Fix a false positive for Layout/SpaceBeforeBrackets when space is used in left bracket. (@koic)
  • #9457: Fix a false positive for Lint/SymbolConversion when hash keys that end with =. (@koic)
  • #9473: Fix an error for Lint/DeprecatedConstants when using __ENCODING__. (@koic)
  • #9452: Fix StyleGuideBaseURL not functioning with nested departments. (@tas50)
  • #9465: Update Metrics/ParameterLists to be able to write MaxOptionalParameters in rubocop_todo.yml. (@dvandersluis)
  • #9433: Fix an error for Style/EvalWithLocation when using eval with block argument. (@koic)

Changes

  • #9437: Improve offense message when there is an allowed range of empty lines. (@dvandersluis)
  • #9476: Mark Style/IfWithBooleanLiteralBranche as unsafe auto-correction. (@koic)

RuboCop 1.9

New features

Bug fixes

  • #9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. (@koic)
  • #9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. (@koic)
  • #9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. (@dvandersluis)

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.9.1 (2021-02-01)

New features

  • #9459: Add AllowedMethods option to Style/IfWithBooleanLiteralBranches and set nonzero? as default value. ([@koic][])

Bug fixes

  • #9431: Fix an error for Style/DisableCopsWithinSourceCodeDirective when using leading source comment. ([@koic][])
  • #9444: Fix error on colorization for offenses with Severity: info. ([@tejasbubane][])
  • #9448: Fix an error for Style/SoleNestedConditional when using nested unless modifier with a single expression condition. ([@koic][])
  • #9449: Fix an error for Style/NilComparison when using x == nil as a guard condition'. ([@koic][])
  • #9440: Fix Lint/SymbolConversion for implicit to_sym without a receiver. ([@dvandersluis][])
  • #9453: Fix infinite loop error for Layout/FirstParameterIndentation when EnforcedStyle: with_fixed_indentation is specified for Layout/ArgumentAlignment. ([@koic][])
  • #9466: Don't correct Style/SingleLineMethods using endless methods if the target ruby is < 3.0. ([@dvandersluis][])
  • #9455: Fix a false positive for Lint/SymbolConversion when hash keys that contain ":". ([@koic][])
  • #9454: Fix an incorrect auto-correct for Style/IfWithBooleanLiteralBranches when using elsif do_something? with boolean literal branches. ([@koic][])
  • #9438: Fix a false positive for Layout/SpaceBeforeBrackets when space is used in left bracket. ([@koic][])
  • #9457: Fix a false positive for Lint/SymbolConversion when hash keys that end with =. ([@koic][])
  • #9473: Fix an error for Lint/DeprecatedConstants when using __ENCODING__. ([@koic][])
  • #9452: Fix StyleGuideBaseURL not functioning with nested departments. ([@tas50][])
  • #9465: Update Metrics/ParameterLists to be able to write MaxOptionalParameters in rubocop_todo.yml. ([@dvandersluis][])
  • #9433: Fix an error for Style/EvalWithLocation when using eval with block argument. ([@koic][])

Changes

  • #9437: Improve offense message when there is an allowed range of empty lines. ([@dvandersluis][])
  • #9476: Mark Style/IfWithBooleanLiteralBranche as unsafe auto-correction. ([@koic][])

1.9.0 (2021-01-28)

New features

Bug fixes

  • #9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. ([@koic][])
  • #9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. ([@koic][])
  • #9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. ([@dvandersluis][])
  • #9387: Fix incorrect auto-correct for Style/NilComparison when using !x.nil? and EnforcedStyle: comparison. ([@koic][])
  • #9411: Fix false negatives for Style/EvalWithLocation for Kernel.eval and when given improper arguments. ([@dvandersluis][])
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection when the rescue body returns the exception variable. ([@asterite][])

... (truncated)

Commits
  • 9624818 Cut 1.9.1
  • 26b188c Update Changelog
  • 72c94e9 [Fix #9453] Fix an infinite loop error for Layout/FirstParameterIndentation
  • 2c2a8e3 [Fix #9465] Update Metrics/ParameterLists to be able to write `MaxOptionalP...
  • 61627d6 Deprecate ConfigurableMax in favour of ExcludeLimit which allows multiple...
  • 851741b Merge pull request #9485 from koic/support_co_contributor_signature
  • fbae4aa Support co-contributor signature for changelog build
  • b614ba8 Avoid tap.
  • 3ef92bb Fix StyleGuideBaseURL not functioning with nested departments
  • 5870d6d Mark Style/IfWithBooleanLiteralBranche as unsafe auto-correction
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies ruby Pull requests that update Ruby code labels Feb 1, 2021
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-1.9.1 branch from 20e9979 to 4e8e059 Compare February 1, 2021 20:38
This cop checks for uses of literal strings converted to a symbol where a literal symbol could be used instead.
https://docs.rubocop.org/rubocop/cops_lint.html#lintsymbolconversion
@pgwillia pgwillia force-pushed the dependabot/bundler/rubocop-1.9.1 branch from 440422e to a3a2442 Compare February 1, 2021 21:20
@pgwillia pgwillia merged commit 089dab6 into master Feb 1, 2021
@pgwillia pgwillia deleted the dependabot/bundler/rubocop-1.9.1 branch February 1, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant