Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.8.1 to 2.9.0 #2019

Merged
merged 4 commits into from
Dec 10, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 9, 2020

Bumps rubocop-rails from 2.8.1 to 2.9.0.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.9.0

New features

  • #362: Add new Rails/WhereEquals cop. (@eugeneius)
  • #339: Add new Rails/AttributeDefaultBlockValue cop. (@cilim)
  • #344: Add new Rails/ArelStar cop which checks for quoted literal asterisks in arel_table calls. (@flanger001)
  • #389: Add IgnoredMethods config option for Rails/FindEach cop. (@tejasbubane)

Bug fixes

  • #371: Fix an infinite loop error for Rails/ActiveRecordCallbacksOrder when callbacks have inline comments. (@fatkodima)
  • #364: Fix a problem that Rails/UniqueValidationWithoutIndex doesn't work in classes defined with compact style. (@sinsoku)
  • #384: Mark unsafe for Rails/NegateInclude. (@koic)
  • #394: Fix false offense detection of Rails/RedundantAllowNil when using both allow_nil and allow_blank on different helpers of the same validator`. (@ngouy)

Changes

  • #383: Require RuboCop 0.90 or higher. (@koic)
  • #365: Mark Rails/SquishedSQLHeredocs unsafe for autocorrection. (@tejasbubane)
Changelog

Sourced from rubocop-rails's changelog.

2.9.0 (2020-12-09)

New features

  • #362: Add new Rails/WhereEquals cop. ([@eugeneius][])
  • #339: Add new Rails/AttributeDefaultBlockValue cop. ([@cilim][])
  • #344: Add new Rails/ArelStar cop which checks for quoted literal asterisks in arel_table calls. ([@flanger001][])
  • #389: Add IgnoredMethods config option for Rails/FindEach cop. ([@tejasbubane][])

Bug fixes

  • #371: Fix an infinite loop error for Rails/ActiveRecordCallbacksOrder when callbacks have inline comments. ([@fatkodima][])
  • #364: Fix a problem that Rails/UniqueValidationWithoutIndex doesn't work in classes defined with compact style. ([@sinsoku][])
  • #384: Mark unsafe for Rails/NegateInclude. ([@koic][])
  • #394: Fix false offense detection of Rails/RedundantAllowNil when using both allow_nil and allow_blank on different helpers of the same validator`. ([@ngouy][])

Changes

  • #383: Require RuboCop 0.90 or higher. ([@koic][])
  • #365: Mark Rails/SquishedSQLHeredocs unsafe for autocorrection. ([@tejasbubane][])
Commits
  • a515b73 Cut 2.9.0
  • 2159b11 Opt out of SuggestExtensions message
  • f5df528 Merge pull request #394 from ngouy/fix-376
  • c79003d [Fix #376] Fix redunctant_allow_nil on different helpers false offense
  • 7801ea7 Merge pull request #392 from tejasbubane/fix-389
  • 3202f6f [Fix #389] Add IgnoredMethods configuration option for Rails/FindEach cop
  • 4890714 Merge pull request #390 from koic/import_enforce_superclass_module
  • dadaf1b Merge pull request #366 from tejasbubane/fix-365
  • 95306d1 [Fix #365] Mark Rails/SquishedSQLHeredocs unsafe for autocorrection
  • 52b8480 Use Cop::Base API for EnforceSuperclass
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies ruby Pull requests that update Ruby code labels Dec 9, 2020
@pgwillia
Copy link
Member

@dependabot rebase

@pgwillia
Copy link
Member

This looks like a reasonable refactor. I'll add it to this PR.

Offenses:

app/models/concerns/draft_properties.rb:25:53: C: Rails/WhereEquals: Use where(uuid: nil) instead of manually constructing SQL. (https://rails.rubystyle.guide/#hash-conditions)
    scope :unpublished, -> { where(status: :active).where('uuid IS NULL') }
                                                    ^^^^^^^^^^^^^^^^^^^^^

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-rails-2.9.0 branch from 671175e to ad8cef2 Compare December 10, 2020 00:09
@pgwillia
Copy link
Member

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-rails-2.9.0 branch from 9bce797 to 0fe76ee Compare December 10, 2020 00:20
@pgwillia pgwillia self-assigned this Dec 10, 2020
@pgwillia pgwillia merged commit 65c5014 into master Dec 10, 2020
@pgwillia pgwillia deleted the dependabot/bundler/rubocop-rails-2.9.0 branch December 10, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants