Bump rubocop from 0.89.1 to 0.90.0 #1845
Conversation
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
requested review from
ConnorSheremeta,
lagoan,
mbarnett,
murny and
pgwillia
as code owners
dependabot-preview
bot
added
dependencies
ruby
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.89.1 to 0.90.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v0.89.1...v0.90.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Style/KeywordParametersOrder: Place optional keyword parameters at the end of the parameters list. (https://rubystyle.guide#keyword-parameters-order)
https://docs.rubocop.org/rubocop/cops_style.html#stylecombinableloops but the thing is, the second depends on the outcome of the first
pgwillia
force-pushed
the
dependabot/bundler/rubocop-0.90.0
branch
from
5c40cc1
to
0584f30
Compare
| @@ -198,7 +198,7 @@ def index(attr, role:, type: :string) | |||
| # attribute but instead is determined by a given lambda | |||
| # | |||
| # Sorry rubocop, but you index something *AS* something. It's communicative. | |||
| def custom_index(attr, type: :string, role:, as:) # rubocop:disable Naming/MethodParameterName | |||
| def custom_index(attr, role:, as:, type: :string) # rubocop:disable Naming/MethodParameterName | |||
There was a problem hiding this comment.
So I gather there's some new cop that has decided that named params with defaults should for some reason be exactly backwards of normal params with defaults?
There was a problem hiding this comment.
Yes. Style/KeywordParametersOrder: Place optional keyword parameters at the end of the parameters list. (https://rubystyle.guide#keyword-parameters-order)
There was a problem hiding this comment.
Huh. I guess this actually makes it more consistent with the other ordering, now that I think about it.
There was a problem hiding this comment.
Style/KeywordParametersOrder: Place optional keyword parameters at the end of the parameters list. (https://rubystyle.guide#keyword-parameters-order)
is the new cop
Docs are here...https://docs.rubocop.org/rubocop/cops_style.html#stylekeywordparametersorder
So i guess if named param has got a default, it should be at the end of the list
(guess im late to the party 😆 )
| @@ -198,7 +198,7 @@ def index(attr, role:, type: :string) | |||
| # attribute but instead is determined by a given lambda | |||
| # | |||
| # Sorry rubocop, but you index something *AS* something. It's communicative. | |||
| def custom_index(attr, type: :string, role:, as:) # rubocop:disable Naming/MethodParameterName | |||
| def custom_index(attr, role:, as:, type: :string) # rubocop:disable Naming/MethodParameterName | |||
There was a problem hiding this comment.
Huh. I guess this actually makes it more consistent with the other ordering, now that I think about it.
Bumps rubocop from 0.89.1 to 0.90.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
95305ffCut 0.90eb04490Merge pull request #8595 from marcandre/struct_autocorrect71c4818Merge branch 'master' into struct_autocorrect6d781b0Revert "Mark Cops and Formatters as private"f69a7a8Merge pull request #8624 from Skipants/masterf877e02FixStyle/CaseLikeIfnot properly handling overriden equality methods6cab599Add workaround to avoid crash in Truffleruby (#8602)2b7607cFix an infinite loop error forLayout/EmptyLineBetweenDefs31a921dUseCop::BaseAPI forLayoutdepartment [T-Z]6c05f69UseCop::BaseAPI forLayoutdepartment [N-S]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: