Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beef up AR migrations with null:false #1704

Merged

Conversation

ConnorSheremeta
Copy link
Contributor

#1685 from #1272 (comment) Beefed up AR migrations by stating that certain attributes cannot be null

@pgwillia
Copy link
Member

Same comment as Shane left on the other one

So we might have to be careful here editing existing migrations like this (i assume we are probably okay here, as these haven't been ran in production yet). So if we all good, then this looks good 👍 (otherwise we will have to add seperate migrations for adding these as null: false)

It looks like the tests aren't passing in the branch, but I think that's expected.

So I'm okay with this being merged 👍

@ConnorSheremeta ConnorSheremeta merged commit 8f3b104 into integration_migration_phase1 Jun 19, 2020
@murny murny deleted the cds/beef-up-migrations branch September 2, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants