Theses ingest rewrite #1670
Merged
Theses ingest rewrite #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorSheremeta
requested review from
lagoan,
mbarnett,
murny and
pgwillia
as code owners
ConnorSheremeta
commented
May 29, 2020
|
|
||
| # Handle rights | ||
| unlocked_obj.rights = thesis_data[:license] | ||
|
|
||
| # Additional fields | ||
| unlocked_obj.date_accepted = thesis_data[:approved_date].to_date if thesis_date[:approved_date].present? | ||
| unlocked_obj.date_submitted = thesis_data[:submitted_date].to_date if thesis_date[:submitted_date].present? | ||
| # Assumes the data received for approved_date and submitted_date follow the pattern of "D/M/Y". |
There was a problem hiding this comment.
This is the assumption I made
There was a problem hiding this comment.
Do you have access to their spreadsheet? (maybe that format should be captured in the spreadsheet so they always follow this date format)
There was a problem hiding this comment.
No I do not. The format is currently not captured in the csv but I think it would be a good idea to have it captured somewhere. I'm not completely sure what the process is but I believe we're given the csv from another department so as long as we communicate this to them. @mbarnett do you know who to communicate this date format to in order to ensure it is always followed?
Generated by 🚫 Danger |
ConnorSheremeta
force-pushed
the
cds/theses-ingest-rewrite
branch
from
07dc4ee
to
e02a9e6
Compare
murny
previously approved these changes
May 29, 2020
murny
approved these changes
Jun 1, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#925
#1586