Added active storage queues to sidekiq configuration #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was depositing items I was finding that a active_storage_analysis queue was filling up but not being processed. https://mikerogers.io/2019/06/06/rails-6-sidekiq-queues.html describes some new queue names for ActiveStorage. I've added the ones that make sense to me. Note that this doesn't resolve the "This file is processing and will be available shortly" message for deposited items like I had hoped it would.
pgwillia
requested review from
ConnorSheremeta,
lagoan,
mbarnett and
murny
as code owners
murny
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When I was depositing items I was finding that a active_storage_analysis queue was filling up but not being processed.
https://mikerogers.io/2019/06/06/rails-6-sidekiq-queues.html describes some new queue names in Rails 6 for ActiveStorage.
I've added the ones that make sense to me.
Note that this doesn't resolve the "This file is processing and will be available shortly" message for deposited items like I had hoped it would.
What's New
Add
active_storage_analysisandactive_storage_purgequeues to sidekiq config. I also addedcriticalandlowbut less certain if they'll actually be used by our application at any point.