Can now go through wizard with an old license #1539
Conversation
Generated by 🚫 Danger |
app/models/draft_item.rb
Outdated
|
|
||
| begin | ||
| CONTROLLED_VOCABULARIES[:license].send(code) | ||
| rescue RuntimeError |
There was a problem hiding this comment.
Is there a way to make this more specific? What error does CONTROLLED_VOCABULARIES[:license].send(code) actually throw when its a bad code in that we want to fallback to try using old_license controlled vocab?
Got similar thinkings as rubocop here around this: https://docs.rubocop.org/en/stable/cops_style/#styleimplicitruntimeerror
If we accidentally had a spelling mistake or something, I believe this would also raise a RuntimeError? this error would then be silenced by this rescue RuntimeError and no one would be any wiser about it, introducing a nasty bug that be hard to debug (since we get no exceptions as we are swallowing them here).
This very well could be valid, just might be extra cautious here
There was a problem hiding this comment.
The error thrown is specified now.
| click_on I18n.t('items.draft.save_and_continue') | ||
| click_on I18n.t('items.draft.save_and_deposit_edits') | ||
| assert_text I18n.t('items.draft.successful_deposit') | ||
|
|
There was a problem hiding this comment.
Nice job adding a test 👍 .
Curious if we can verify that the edited item on the show page actually has a an old license attached to it?
My worry is this test just checked that we can walk through the wizard. What if the wizard drops the license or fallbacks to a default and just allowed you to save? But if we can assert the final item after its been edited that it still has the correct license (an old license in this case), then we can be sure it all worked successfully 👍
ConnorSheremeta
requested review from
lagoan,
mbarnett and
pgwillia
as code owners
|
Not sure how I requested review from you three right now, its not required as Shane as already approved. Looks like I cannot remove you three? Did we turn on a new setting on the repo? |
PR #1359