Rename methods to be more informative, fix bug with double rendering … #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murny
commented
Mar 2, 2020
| @@ -46,7 +46,7 @@ def thumbnail | |||
| end | |||
|
|
|||
| # compatibility with the thumbnail API used in Items/Theses and Communities | |||
| def thumbnail_url(args = { resize: '100x100', auto_orient: true }) | |||
| def thumbnail_path(args = { resize: '100x100', auto_orient: true }) | |||
| return nil unless thumbnail.present? && thumbnail.blob.present? | |||
|
|
|||
| Rails.application.routes.url_helpers.rails_representation_path(thumbnail.variant(args).processed) | |||
There was a problem hiding this comment.
As you notice here we are returning the rails_representation_path instead of the rails_representation_url in this thumbnail_url helpers. Lets rename these to thumbnail_path as this is what its actually returning
murny
commented
Mar 2, 2020
| @@ -26,15 +26,15 @@ | |||
| <meta property="og:locale" content="en_US"> | |||
| <meta property="og:title" content="<%= page_title %>"> | |||
| <meta property="og:description" content="<%= page_description %>"> | |||
| <meta property="og:image" content="<%= request.base_url + page_image %>"> | |||
| <meta property="og:image" content="<%= page_image_url %>"> | |||
There was a problem hiding this comment.
Move this request.base_url concatenation into the helper itself. This was causing the bug on the default images. Update the helper name to be more informative (page_image vs page_image_url)
murny
commented
Mar 2, 2020
| @@ -2,6 +2,16 @@ | |||
|
|
|||
| class PageLayoutHelperTest < ActionView::TestCase | |||
|
|
|||
| attr_reader :request | |||
There was a problem hiding this comment.
We don't have access to request inside test helpers. Some setup to fake this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…page image url
Noticed this bug when working on webpacker. It works fine on an item/community, but broken on the default image url. Here is what this page_image helper out puts for default image url in production currently:
Notice the root url and image url being appended together which is not a valid url.
Part of the problem i think is the confusion between
urlandpath. So cleaned up those model methods to be more informative.