Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Decorators for OAI:DC and OAI:ETDMS #1460

Merged
merged 8 commits into from
Feb 13, 2020

Conversation

mbarnett
Copy link
Contributor

@mbarnett mbarnett commented Feb 7, 2020

Context

Now that we have introduced Draper for decorators, we're setting up specialized Metadata decorators that can acts as adapters between arbitrary classes and the metadata rendering logic needed for Oaisys and ActsAsRDFable.

Changes

  • Adds OAI:DC decorator for the Item model
  • Adds OAI:ETDMS decorator for the Thesis model
  • Adds special case to the download controller to handle downloading files whose names have spaces in them but which LAC cannot handle without removing all spaces and space-escaping.
  • Tweaks Draper setup and helper registration in order to ensure consistent behaviour for decorators whether they are run by the main application or an engine.

@ualbertalib-bot
Copy link

ualbertalib-bot commented Feb 7, 2020

1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by 🚫 Danger

murny
murny previously approved these changes Feb 13, 2020
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍. Great job on explaining the tricky pieces with well written code comments

gif

murny
murny previously approved these changes Feb 13, 2020
@mbarnett mbarnett merged commit 8902181 into integration_postmigration Feb 13, 2020
@mbarnett mbarnett deleted the msb/metadata_decorators branch February 13, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants