Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up papertrail gem #1437

Merged
merged 5 commits into from
Jan 29, 2020
Merged

Set up papertrail gem #1437

merged 5 commits into from
Jan 29, 2020

Conversation

ConnorSheremeta
Copy link
Contributor

@ConnorSheremeta ConnorSheremeta commented Jan 24, 2020 •
edited
Loading

  • Set up papertrail gem
  • Created callback
  • Fixed bug with error on save due to logo_id

@ConnorSheremeta
Create callback for papertrail ualbertalib#1364
4257f23 
- Created callback
- Fixed bug with error on save due to logo_id
@ConnorSheremeta ConnorSheremeta changed the title Create callback for papertrail #1364 Set up papertrail gem Jan 27, 2020
@murny
Copy link
Contributor

murny commented Jan 27, 2020

Looks pretty good 👍 .

Curious though if we can disable papertrail for the test suite? Probably unneeded hits on the database when running automated tests

They have a little guide here: https://github.com/paper-trail-gem/paper_trail#7a-minitest

@ConnorSheremeta ConnorSheremeta requested review from murny and removed request for murny January 27, 2020 23:50
murny
murny approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif

@ConnorSheremeta ConnorSheremeta merged commit dd4bc13 into ualbertalib:integration_postmigration Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murny murny murny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ConnorSheremeta @murny