Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-performance from 1.4.0 to 1.4.1 #1226

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Jul 29, 2019

Bumps rubocop-performance from 1.4.0 to 1.4.1.

Release notes

Sourced from rubocop-performance's releases.

RuboCop Performance 1.4.1

Bug fixes

  • #67: Fix an error for Performance/RedundantMerge when MaxKeyValuePairs option is set to null. (@​koic)
  • #73: Fix a false negative for Performance/RegexpMatch when MatchData is not detected in if branch of guard condition. (@​koic)
Changelog

Sourced from rubocop-performance's changelog.

1.4.1 (2019-07-29)

Bug fixes

  • #67: Fix an error for Performance/RedundantMerge when MaxKeyValuePairs option is set to null. (@​koic)
  • #73: Fix a false negative for Performance/RegexpMatch when MatchData is not detected in if branch of guard condition. (@​koic)
Commits
  • 6f49b5e Cut 1.4.1
  • d7f063e Merge pull request #73 from koic/fix_false_negative_for_performance_regexp_match
  • 12fc7fb Fix an error for Performance/RegexpMatch
  • 367c631 Fix a false positive for Performance/RegexpMatch
  • d8026ba Fix a false negative for Performance/RegexpMatch
  • c761793 Reduce .rubocop_todo.yml
  • 69ba7f7 Merge pull request #68 from koic/fix_an_error_for_redundant_merge
  • e286f25 [Fix #67] Fix an error for Performance/RedundantMerge
  • 29316f4 Suppress an offense
  • ec90eb8 Merge pull request #65 from koic/remove_unnecessary_code_to_suppress_warnings
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it). To ignore the version in this PR you can just close it
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@pgwillia
Copy link
Member

Offenses:
app/controllers/redirect_controller.rb:99:29: C: Performance/RegexpMatch: Use match? instead of =~ when MatchData is not used. (https://github.com/JuanitoFatas/fast-ruby#regexp-vs-stringmatch-vs-string-vs-stringmatch-code-)
    return params[:uuid] if /^uuid:.+/ =~ params[:uuid]
                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
232 files inspected, 1 offense detected

@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/rubocop-performance-1.4.1 branch from 5b7f186 to 4981cc6 Compare July 30, 2019 16:33
@pgwillia pgwillia merged commit 22a0a55 into master Jul 30, 2019
@pgwillia pgwillia deleted the dependabot/bundler/rubocop-performance-1.4.1 branch July 30, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant