add omniauth-rails_csrf_protection gem and only use post requests #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
commented
Jul 23, 2019
| @@ -90,12 +90,12 @@ | |||
| </li> | |||
| <% else %> | |||
| <li role="presentation" class="nav-item"> | |||
| <%= link_to t('.links.login'), '/auth/saml', class: 'nav-item nav-link text-nowrap' %> | |||
| <%= link_to t('.links.login'), '/auth/saml', class: 'nav-item nav-link text-nowrap', method: :post %> | |||
There was a problem hiding this comment.
Alternately could use
Suggested change
| <%= link_to t('.links.login'), '/auth/saml', class: 'nav-item nav-link text-nowrap', method: :post %> | |
| <%= button_to t('.links.login'), '/auth/saml', class: 'nav-item nav-link text-nowrap' %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this mitigates CVE-2015-9284 by implementing the suggested fix https://github.com/ualbertalib/jupiter/network/alert/Gemfile.lock/omniauth/open