add current and future ruby to travis #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgwillia
force-pushed
the
travis_rvm_matrix
branch
2 times, most recently
from
1bdf6bb
to
fada8b8
Compare
jefferya
previously approved these changes
Apr 16, 2019
Gemfile.lock
Outdated
| @@ -576,4 +576,4 @@ DEPENDENCIES | |||
| wicked | |||
|
|
|||
| BUNDLED WITH | |||
| 1.17.3 | |||
| 2.0.1 | |||
There was a problem hiding this comment.
The rpm build environment Henry was using for another project (cwrc_preservation) was having trouble with Bundler v2. Maybe check with him before merging.
pgwillia
commented
Apr 16, 2019
pgwillia
commented
Apr 16, 2019
pgwillia
force-pushed
the
travis_rvm_matrix
branch
from
3d33ce6
to
9cb6709
Compare
jefferya
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This application currently runs in production with Ruby 2.4. Some of our other application run with 2.5 and 2.6 is the newest. We can use travis to smoke test whether or not the changes we make are future compatible.
The con of this is that we're more likely to be caught in the flapping tests.