Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI upgrades from datacite make workarounds unnecessary #1030

Merged
merged 3 commits into from
Mar 8, 2019

Conversation

pgwillia
Copy link
Member

Cleaned up the TODOs and changes because datacite has fixes for these upstream and the workarounds are no longer necessary.

datacite/cheetoh#24

weiweishi
weiweishi previously approved these changes Mar 7, 2019
Copy link
Contributor

@weiweishi weiweishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will have to do some testing against their prod server once this is deployed, as I'm not 100% sure if the merged PRs have been deployed to their production service based on past experiences.

Copy link
Member

@pbinkley pbinkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely.

@pgwillia pgwillia merged commit 5a7241d into ualbertalib:master Mar 8, 2019
@pgwillia pgwillia deleted the doi_upgrade_datacite branch March 8, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants