Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix faker deprecations by adding namespace #1019

Merged
merged 3 commits into from
Feb 19, 2019
Merged

fix faker deprecations by adding namespace #1019

merged 3 commits into from
Feb 19, 2019

Conversation

pgwillia
Copy link
Member

@pgwillia pgwillia commented Feb 15, 2019 •
edited
Loading

follow up to #1014

before:

$ bundle exec rails db:seed
Starting seeding of dev database...
rake aborted!
NoMethodError: undefined method `unique' for Faker::GameOfThrones:Class

after:

$ bundle exec rails db:seed
Starting seeding of dev database...
Database seeded successfully!

murny
murny approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@murny murny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gif

@murny murny merged commit 9a12b91 into ualbertalib:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murny murny murny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgwillia @murny