Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extraneous text appearing along with Conference/Workshop Poster in Item type filter #879

Closed
sfarnel opened this issue Sep 27, 2018 · 1 comment
Closed

Extraneous text appearing along with Conference/Workshop Poster in Item type filter #879

sfarnel opened this issue Sep 27, 2018 · 1 comment
Assignees
@weiweishi
Labels
bug needs-review

Comments

@sfarnel
Copy link
Member

sfarnel commented Sep 27, 2018

Describe the bug
Extraneous text appearing with item type Conference/Workshop Poster in Item Type filter.

To Reproduce
Steps to reproduce the behavior:

  1. Go to ERA home page
  2. Click on Search
  3. Scroll down to the item type filter
  4. Click on Show 4 more
  5. See "translation error: ..." that shows as part of the item type

Expected behavior
Item type should appear as Conference/Workshop Poster

Screenshots
image

Desktop (please complete the following information):

  • Windows 7 Enterprise
  • Firefox 60.2.4
@sfarnel sfarnel added the bug label Sep 27, 2018
@weiweishi
Copy link
Contributor

discovered typo in the code. Will make the change and hopefully to get into the next release tomorrow.

@weiweishi weiweishi self-assigned this Oct 11, 2018
weiweishi added a commit that referenced this issue Oct 11, 2018
@weiweishi
fix typo that causes #879
ebc9943
@weiweishi weiweishi mentioned this issue Oct 12, 2018
Merged
murny added a commit that referenced this issue Oct 17, 2018
@murny
Merge pull request #889 from ualbertalib/879-presentation-type
78676af 
fix typo that causes #879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiweishi weiweishi

Labels
bug needs-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weiweishi @sfarnel