Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupiter: Deposit item type "Conference/Workshop Presentation" becomes "Conference Paper" #789

Closed
pbinkley opened this issue Jul 24, 2018 · 15 comments
Assignees
Labels

Comments

@pbinkley
Copy link
Member

pbinkley commented Jul 24, 2018

Describe the bug
When an item is deposited with item type "Conference/Workshop Presentation", it becomes "Conference Paper" once the item is saved.

To Reproduce
Steps to reproduce the behavior:

  1. Deposit an item with Item type "Conference/Workshop Presentation"
  2. Save

Expected behavior
Item type should remain "Conference/Workshop Presentation"

Additional context
I've just deposited an item this way in UAT http://uat.library.ualberta.ca/items/f63df45f-c375-4104-a69c-0ac90cc3f2f2

Agreed strategy

@pbinkley pbinkley added the bug label Jul 24, 2018
@sfarnel
Copy link
Member

sfarnel commented Jul 25, 2018

The item types in the list do not match up with the data dictionary. @weiweishi @pbinkley @leahvanderjagt can @danydvd and I touch base with you to review and make changes as needed?

@sfarnel
Copy link
Member

sfarnel commented Jul 25, 2018

Sorry; should have added further detail. Is this a question of the display label not matching on the item view page? We can easily update this in the data dictionary as I believe this may be an error there. If it's more about the underlying property then of course happy to provide further detail on the way it was chosen and talk through other potential options.

@pbinkley
Copy link
Member Author

pbinkley commented Jul 25, 2018 via email

@pbinkley
Copy link
Member Author

I've confirmed that the item was saved with type: http://vivoweb.org/ontology/core#ConferencePaper in Fedora.

@weiweishi
Copy link
Contributor

weiweishi commented Jul 25, 2018 via email

@pbinkley
Copy link
Member Author

pbinkley commented Jul 25, 2018 via email

@weiweishi
Copy link
Contributor

weiweishi commented Jul 25, 2018 via email

@sfarnel
Copy link
Member

sfarnel commented Jul 25, 2018

When we investigated this we didn't find a vocab that a general property for "presentation" so rather than minting our own we went with the designation between paper/poster. But I can see instances where something more generic may be worthwhile. If this is so desired, we can a) investigate whether there may be a vocab now that has a usable property, b) define our own. I will ask @danydvd to do some investigating.

@danydvd
Copy link

danydvd commented Jul 25, 2018

vivoweb vocabulary has a property called presentation. It is used for: Encompasses talk, speech, lecture, slide lecture, conference presentation.
If this sounds like a proper datatype, I can add it the Data Dictionary.

@sfarnel
Copy link
Member

sfarnel commented Jul 25, 2018

Thanks @danydvd this would seem to capture the more generic 'presentation'.

So my understanding then is:

Is that correct @pbinkley @weiweishi @leahvanderjagt @danydvd ?

@pbinkley
Copy link
Member Author

pbinkley commented Jul 25, 2018 via email

@weiweishi weiweishi changed the title Deposit item type "Conference/Workshop Presentation" becomes "Conference Paper" Jupiter: Deposit item type "Conference/Workshop Presentation" becomes "Conference Paper" Aug 8, 2018
@weiweishi
Copy link
Contributor

@leahvanderjagt has approved the strategy to handle this new content type.

@danydvd
Copy link

danydvd commented Aug 8, 2018

@mbarnett
Copy link
Contributor

mbarnett commented Aug 8, 2018

Note from grooming meeting:

This may require us to either:

  1. take the site down to update the URIs all at once

or

  1. add the new URI (while retaining the old URI), cleaning up the data at our leisure, and then removing the old URI once that process is complete

Removing the old URI but leaving the site up will cause the application to crash/misbehave when displaying or editing items with the old URI on them.

@weiweishi
Copy link
Contributor

Deployed to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants