Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Images on Item show page are being styled as Thumbnails #1675

Closed
murny opened this issue Jun 1, 2020 · 0 comments · Fixed by #1690
Closed

Feature Images on Item show page are being styled as Thumbnails #1675

murny opened this issue Jun 1, 2020 · 0 comments · Fixed by #1690
Assignees

Comments

@murny
Copy link
Contributor

murny commented Jun 1, 2020

From #1666

We displaying this feature image as a "thumbnail" on Item show page which has the following css:

.j-thumbnail {
    max-width: 135px;
    max-height: 175px;
}

But we have more real-estate to work with here? Should we increase the size of these feature
images on the show page, so users can view the image better?

This actually appears to be a regression. We were originally styling them as feature images
before using the following css: https://github.com/ualbertalib/jupiter/blob/integration_postmigration/app/javascript/styles/image.scss#L6-L9. But when we added the fallback image about 9 months ago, we changed everything (including the feature images) to be styled as thumbnails (.j-thumbnail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant