Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate "This file is processing and will be available shortly " #1669

Closed
pgwillia opened this issue May 28, 2020 · 1 comment
Closed
Assignees

Comments

@pgwillia
Copy link
Member

Describe the bug
As an admin or a non-admin user, a successful deposit results in "This file is processing and will be available shortly"
image

It appears that this doesn't resolve after the sidekiq queue has been cleared or any amount of waiting.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Deposit'
  2. Fill out the wizard
  3. Add some files
  4. Click on "Save"
  5. See "This file is processing and will be available shortly" for each of the files you've added

Expected behavior
The view and download links should be available when the files are completed processing.

Additional context
If fileset_uuid is not present then the processing message will be shown

<% if file.present? && file.fileset_uuid.present? %>

The fileset_uuid should be set here so I suspect that we're not reaching line 134
def add_and_ingest_files(file_handles = [])
return if file_handles.blank?
raise 'Item not yet saved!' if id.nil?
file_handles.each do |fileio|
attached = files.attach(io: fileio, filename: File.basename(fileio.path))
# TODO: Do something smarter here if not attached
next unless attached
attachment = files.attachments.last
attachment.fileset_uuid = UUIDTools::UUID.random_create
attachment.save!
end
end

Rails 6 update made a few changes to ActiveStorage which may or may not be related https://edgeguides.rubyonrails.org/6_0_release_notes.html#active-storage

@murny murny self-assigned this Jun 5, 2020
murny added a commit that referenced this issue Jun 10, 2020
murny added a commit that referenced this issue Jun 10, 2020
…ssing

#1669: Make sure we are setting fileset_uuid whenever we add files for items/theses
@murny
Copy link
Contributor

murny commented Jun 12, 2020

Should be fixed with above PR being merged. Closing issue.

@murny murny closed this as completed Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants