Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup all references of is_published_in_era and drafts scope on DraftItem/DraftThesis #1614

Closed
murny opened this issue Apr 24, 2020 · 1 comment
Closed

Cleanup all references of is_published_in_era and drafts scope on DraftItem/DraftThesis #1614

murny opened this issue Apr 24, 2020 · 1 comment
Assignees
@murny

Comments

@murny
Copy link
Contributor

murny commented Apr 24, 2020

From discovery work found in #1556 we discovered both is_published_in_era and drafts scope on DraftItem/DraftThesis are not doing a whole lot currently in ERA and is just leading to confusion.

Let's clean this code up
@murny murny self-assigned this Apr 27, 2020
murny added a commit that referenced this issue Apr 28, 2020
@murny
#1614: Remove is_published_in_era column and all use cases of it (dra…
1c3b798 
…fts scope mainly)
@murny murny mentioned this issue Apr 28, 2020
Merged
murny added a commit that referenced this issue May 1, 2020
@murny
Merge pull request #1622 from ualbertalib/remove-is-published-in-era-…
3e024be 
…column

#1614: Remove is_published_in_era column and all use cases of it (drafts scope)
@murny
Copy link
Contributor Author

murny commented May 4, 2020

This has now been merged. Closing issue.

@murny murny closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@murny murny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@murny