Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor inactive draft cleanup rake task to be sidekiq cron job #1611

Closed
murny opened this issue Apr 24, 2020 · 1 comment
Closed

Refactor inactive draft cleanup rake task to be sidekiq cron job #1611

murny opened this issue Apr 24, 2020 · 1 comment
Assignees

Comments

@murny
Copy link
Contributor

murny commented Apr 24, 2020

From discovery work found in #1556:

Rake task to cleanup inactive draft objects should be turned into a sidekiq cron job and be run once in a while? For history's sake, this rake task was created before we had sidekiq-cron in our project. But to this date, I highly doubt we ever ran this rake task in production since we implemented this rake task. This could be a big improvement and help us cleanup all the inactive draft objects in our DB.

So as it says, we should refactor the current rake task: https://github.com/ualbertalib/jupiter/blob/integration_postmigration/lib/tasks/jupiter.rake#L6-L24

And instead make this a sidekiq cron job which runs periodically, as I highly doubt we ever used this rake task in production.

@murny murny self-assigned this May 1, 2020
murny added a commit that referenced this issue May 8, 2020
…up-rake-task-to-sidekiq-job

#1611: Refactor inactive draft cleanup rake task to be a sidekiq cron…
@murny
Copy link
Contributor Author

murny commented Jun 2, 2020

This has been merged. Closing issue.

@murny murny closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant