Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in StyleLint NPM package #1120

Closed
pgwillia opened this issue May 3, 2019 · 2 comments
Closed

Bring in StyleLint NPM package #1120

pgwillia opened this issue May 3, 2019 · 2 comments
Labels
technical-debt

Comments

@pgwillia
Copy link
Member

pgwillia commented May 3, 2019

https://github.com/ualbertalib/discovery/blob/1b1904c69d07ef1528f48b3862fece839e2274d9/Gemfile#L50

The Sass core team is now building Sass in Dart instead of Ruby, and will no longer be maintaining the Ruby implementation unless a maintainer steps up to help. Since the SCSS-Lint project relies on the Ruby Sass implementation, this means it will eventually not support the latest Sass features and bug fixes.

Two alternatives worthy of consideration are stylelint and sass-lint, with sass-lint having closer feature parity to SCSS-lint.
@murny murny mentioned this issue Jan 24, 2020
Closed
8 tasks
@murny murny changed the title Replace scss_lint gem Bring in StyleLint NPM package Mar 6, 2020
@murny
Copy link
Contributor

murny commented Mar 6, 2020

We are now on Webpacker, I have removed SCSS LInt gem. But we should bring in something like Stylelint from NPM.

More info: https://stylelint.io/

murny added a commit that referenced this issue Jul 10, 2020
@murny
#1120: Bring in styelint.io, cleanup css, and add to CI
8581969
@murny murny mentioned this issue Jul 10, 2020
Merged
murny added a commit that referenced this issue Jul 14, 2020
@murny
Merge pull request #1753 from ualbertalib/add-stylelint
b535e25 
#1120: Bring in styelint.io, cleanup css, and add to CI
@murny
Copy link
Contributor

murny commented Jul 14, 2020

Jupiter is now using stylelint.io so we can now close this.

@murny murny closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgwillia @murny