Split codegen into a sub-project #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masklinn
force-pushed
the
split-codegen
branch
9 times, most recently
from
3e6e4c1 to
419f218
Compare
masklinn
force-pushed
the
split-codegen
branch
4 times, most recently
from
ed2893f to
34188ce
Compare
The goal of this is the ability to generate wheels for precompiled instances of uap-core, at whatever version we want. 1. It resolves ua-parser#146 by splitting the versioning of the API and that of the (pre-compiled) data, this is an issue for 1.0 as that detaches uap-python's versioning from uap-core's. 2. It allows users to update the API and the precompiled dataset separately, something they would otherwise need to do via yaml. 3. It fixes ua-parser#221 by allowing the regular release of "preview" precompiled regexes from uap-core snapshots e.g. we could release 0.19.dev202412 at the start of december with whatever uap-core merged between the previous prerelease and then. This should not be picked up by pip by default, but would allow users to access those prerelases via `pip install --pre`. 4. If done well enough, it might allow users to build bespoke precompiled datasets so they don't have to pick between custom rules and precompiled (not sure there's any demand for this but it seems like it might be useful). 5. If it works well enough it might actually be possible to have 0.x use the legacy codegen package meaning it should not need to be updated anymore. This is implemented via hatch build hooks (which seem seem simpler than doing it via setuptools in the end). Adding `regexes.yaml` to the sdist via artifacts is a bit strange but necessary in order to generate a complete sdist which a wheel can be built from (even though the release script will likely only push the wheel).
- The workflow does no release if a valid environment is not selected. - By default, the workflow will create a .devN release using the current uap-core master.
masklinn
force-pushed
the
split-codegen
branch
from
34188ce to
48919ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core would likely be shared e.g. run tests, build wheel, push, however the second one needs to update the submodule to the current master of uap-core first.
If there has been no update to uap-core, it should generate the same
.devNversion number, and thus pushing the wheel should fail with an "already exists". Need to find what the code is for that and ignore this error specifically. Once I get to that.This can be a completely automated process using trusted publishing though.