Fix OS version detection for Chrome OS #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same (rebase) game ... |
robcowie
reviewed
Apr 1, 2017
regexes.yaml
Outdated
| @@ -925,6 +925,9 @@ os_parsers: | |||
| # http://code.google.com/p/chromium-os/issues/detail?id=11573 | |||
| # http://code.google.com/p/chromium-os/issues/detail?id=13790 | |||
| ########## | |||
| # Newer versions of Chrome OS require you to look at the Chrome version to get the real version | |||
| - regex: '(CrOS) [a-z0-9_]+ \d\d\d\d\.\d+\.\d+\) .* Chrome/(\d+)\.(\d+)\.(\d+)\.(\d+)' | |||
There was a problem hiding this comment.
Will the leading CrOS number always be 4 digits? Might it be worth matching any number of digits to future proof it? i.e. (CrOS) [a-z0-9_]+ \d+\.\d+\.\d+\)? Just a thought.
|
@seandilda Can you please rebase and fix the failing tests? |
|
I'm not using this project anymore and don't currently have the spare cycles for this. Please feel free to close this PR if no one else is willing to take this on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.