Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only define WIN32_EXPORT if LIBUS_BUILDING_DLL is defined #191

Closed
wants to merge 1 commit into from
Closed

Only define WIN32_EXPORT if LIBUS_BUILDING_DLL is defined #191

wants to merge 1 commit into from

Conversation

traversaro
Copy link

Fix #184

@uNetworkingAB
Copy link
Contributor

But this is not the fix we discussed

@traversaro
Copy link
Author

I implemented what suggested in #184 . I avoided to use the generic _DLL macro as the libusockets.h file is included also in compilation units that are not the uSockets ones, and in that case you do not want to WIN32_EXPORT to be define to __declspec(dllexport) , so it is useful to avoid to use the _DLL generic macro and use instead a uSockets-specific macro.

@traversaro
Copy link
Author

traversaro commented Jan 2, 2023 •
edited
Loading

But this is not the fix we discussed

My bad, I added the explanatory comment later in the PR, sorry for that.

@traversaro
Copy link
Author

Superseded by #184 .

@traversaro traversaro closed this Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

please remove the dllexport of static libs
2 participants
@traversaro @uNetworkingAB