Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch filter inputs to type="search" #768

Closed
8 tasks done
tophf opened this issue Oct 31, 2019 · 1 comment
Closed
8 tasks done

Switch filter inputs to type="search" #768

tophf opened this issue Oct 31, 2019 · 1 comment
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@tophf
Copy link

tophf commented Oct 31, 2019

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Suggesting to switch filter inputs to type="search" so even without using a <form> wrapper the users will get the benefit of having an automatically shown neat x to reset the input via mouse click on the filled inputs. Currently supported in Chrome, not in Firefox.

Implementation: https://github.com/tophf/uBlock/commit/196ba2d758a0738c8ac801c8676dc124cec1edd7

A specific URL where the issue occurs

[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior:

[What you expected to happen]

Actual behavior:

[What actually happened]

Your environment

  • uBlock Origin version: latest
  • Browser Name and version: any
  • Operating System and version: any
@uBlock-user uBlock-user added the enhancement New feature or request label Oct 31, 2019
gorhill added a commit to gorhill/uBlock that referenced this issue Nov 3, 2019
Related issue:
- uBlockOrigin/uBlock-issues#768

So that the input fields can gain extra built-in
browser widgets useful in search fields.
@gorhill
Copy link
Member

gorhill commented Nov 3, 2019

Good idea, thanks for the suggestion.

@gwarser gwarser added the fixed issue has been addressed label Nov 5, 2019
@gwarser gwarser closed this as completed Nov 5, 2019
hawkeye116477 pushed a commit to hawkeye116477/uBlock-for-firefox-legacy that referenced this issue Dec 21, 2020
Related issue:
- uBlockOrigin/uBlock-issues#768

So that the input fields can gain extra built-in
browser widgets useful in search fields.

(For now only on Chromium)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

4 participants