Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicted with another extension called WebRTC Protect #1928

Closed
5 tasks done
Mishasama opened this issue Jan 13, 2022 · 22 comments
Closed
5 tasks done

Conflicted with another extension called WebRTC Protect #1928

Mishasama opened this issue Jan 13, 2022 · 22 comments
Labels
external issue involving an external factor

Comments

@Mishasama
Copy link

Prerequisites

  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
  • The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
  • I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

  • uBO is the only extension
  • using a new, unmodified browser profile

Description

After the recent uBO update. The uBO conflicted with another extension called WebRTC Protect. It makes the WebRTC Protect reports there is another extension controlling the settings.

A specific URL where the issue occurs

https://add0n.com/webrtc-protect.html

Steps to Reproduce

  1. Install both uBO and WebRTC Protect.
  2. Open a new page.
  3. See the WebRTC Protect reports.

Expected behavior

They should not conflict with each other. And keep all IP not leaked by WebRTC.

Actual behavior

The WebRTC Protect reports there is another extension controlling the settings. And the WebRTC was leaking the IPs.

Configuration

uBlock Origin: 1.40.4
Chromium: 95
filterset (summary): 
  network: 98029
  cosmetic: 57481
  scriptlet: 19422
  html: 0
listset (total-discarded, last updated): 
  added: 
    https://easylist-downloads.adblockplus.org/easylistchina.txt: 25257-16, 3d.3h.9m
    https://raw.githubusercontent.com/cjx82630/cjxlist/master/cjx-annoyance.txt: 1894-2, 3d.3h.8m
    https://raw.githubusercontent.com/cjx82630/cjxlist/master/cjx-ublock.txt: 63-63, 3d.3h.7m
    https://raw.githubusercontent.com/cjx82630/cjxlist/master/cjxlist.txt: 516-3, 1d.5h.51m
    CHN-0: 27372-25298, 3d.3h.13m
    ublock-annoyances: 4361-9, 3d.3h.6m
  default: 
    JPN-1: 5688-13, 3d.3h.12m
    easylist: 62817-495, 3d.3h.11m
    easyprivacy: 26613-92, 3d.3h.10m
    plowe-0: 3682-825, 11d.7h.20m
    ublock-abuse: 76-0, 1h.45m
    ublock-badware: 3658-67, 2d.19h
    ublock-filters: 30140-175, 1d.1h.50m
    ublock-privacy: 186-4, 1d.1h.48m
    ublock-unbreak: 1716-44, 1d.1h.47m
    urlhaus-1: 8135-0, 17h.46m
filterset (user): [array of 17 redacted]
trustedset: 
  added: [array of 22 redacted]
  removed: 
    chrome-scheme
    edge-scheme
    wyciwyg-scheme
switchRuleset: 
  added: [array of 6 redacted]
urlRuleset: 
  added: [array of 7 redacted]
modifiedUserSettings: 
  advancedUserEnabled: true
  cloudStorageEnabled: true
  webrtcIPAddressHidden: true
modifiedHiddenSettings: [none]
supportStats: 
  launchToReadiness: 5819 ms (selfie)
@u-RraaLL
Copy link
Contributor

u-RraaLL commented Jan 13, 2022

Try this:

  1. Back up your settings: https://github.com/gorhill/uBlock/wiki/Dashboard:-Settings#backuprestore-section
  2. Edit the file.
  3. Find webrtcIPAddressHidden: true inside, remove it and save.
  4. Restore from backup.

Does it work now?

If it didn't work, perhaps you need to change the setting to false instead of removing it.

@gwarser
Copy link

gwarser commented Jan 13, 2022

It makes the WebRTC Protect reports there is another extension controlling the settings.

What does it look like?

Did you ever changed WebRTC settings manually in your browser? Which browser it is?

@gorhill
Copy link
Member

gorhill commented Jan 13, 2022

Find webrtcIPAddressHidden: true inside, remove it and save

It's not necessary, uBO does not touch webrtc setting in the browser, we have to emphasize this.

@Mishasama,

Which exact browser are you using? Brave is reportedly interfering with webrtc setting, and people misdiagnose this to uBO -- uBO no longer ever touch webrtc setting since 1.38.0, so it's just impossible that it interferes.

@gorhill gorhill added the unable to reproduce cannot reproduce the issue label Jan 13, 2022
@Mishasama
Copy link
Author

Find webrtcIPAddressHidden: true inside, remove it and save

It's not necessary, uBO does not touch webrtc setting in the browser, we have to emphasize this.

@Mishasama,

Which exact browser are you using? Brave is reportedly interfering with webrtc setting, and people misdiagnose this to uBO -- uBO no longer ever touch webrtc setting since 1.38.0, so it's just impossible that it interferes.

Chrome 95.0.4638.69
I see the Wiki says uBO does not touch WebRTC anymore. But it seems after the not touch update, the WebRTC protect report conflicted. They both work fine before.

Try this:

  1. Back up your settings: https://github.com/gorhill/uBlock/wiki/Dashboard:-Settings#backuprestore-section
  2. Edit the file.
  3. Find webrtcIPAddressHidden: true inside, remove it and save.
  4. Restore from backup.

Does it work now?

If it didn't work, perhaps you need to change the setting to false instead of removing it.

Not work.

@gorhill
Copy link
Member

gorhill commented Jan 13, 2022

I couldn't reproduce a conflict as per your repro steps, and it's expected since uBO does not touch that setting.

You are failing to provide key information:

  • Open a new page.

Which exact web page? This is important to test exactly the same way.

  • See the WebRTC Protect reports.

How does that look like? There is no popup panel for the WebRTC Protect extension. Where is that report? Provide screenshot.

@gwarser
Copy link

gwarser commented Jan 13, 2022

@Mishasama do you see this:

image

?

Do you have any other add-ons? (Check puzzle piece icon!)

@Mishasama
Copy link
Author

I couldn't reproduce a conflict as per your repro steps, and it's expected since uBO does not touch that setting.

You are failing to provide key information:

  • Open a new page.

Which exact web page? This is important to test exactly the same way.

  • See the WebRTC Protect reports.

How does that look like? There is no popup panel for the WebRTC Protect extension. Where is that report? Provide screenshot.

Any page. That's no matter.

It looks like this.
image

@Mishasama do you see this:

image

?

Do you have any other add-ons? (Check puzzle piece icon!)

I have other extensions. But only WebRTC Protect is activating. And this problem was gone after disabling uBO.

@gorhill
Copy link
Member

gorhill commented Jan 14, 2022

problem was gone after disabling uBO

You will have to report to Chromium devs then, uBO does not touch the chrome.privacy.network.webRTCIPHandlingPolicy, so it makes no sense that the browser would report that uBO is using it -- and so far nobody has else has reported such issue, except for those who keep misdiagnosing the issue as originating from uBO. Please file your issue here: https://bugs.chromium.org/p/chromium/issues/entry.

I have other extensions

Please provide screenshot showing all your extensions from chrome://extensions and screenshot showing the issue (as @gwarser provided above), and screenshot of exactly the same but without uBO enabled.

Also mind providing other important details such as whether this involves incognito tabs/windows, and whether you changed settings in chrome://flags.

@uBlock-user
Copy link
Contributor

uBlock-user commented Jan 14, 2022

OP has another webRTC extension installed -- https://chrome.google.com/webstore/detail/webrtc-leak-prevent/eiadekoaikejlgdbkbdfeijglgfdalml hence the browser behaviour.

Nvm, that was on @gwarser

@uBlock-user uBlock-user added the invalid not a uBlock issue label Jan 14, 2022
@uBlock-user uBlock-user reopened this Jan 14, 2022
@gorhill gorhill removed the invalid not a uBlock issue label Jan 14, 2022
@gorhill
Copy link
Member

gorhill commented Jan 14, 2022

That's @gwarser's screenshot. But I don't see any other explanation that there is another extension interfering.

@uBlock-user
Copy link
Contributor

Yeah I was misled as I didn't have the page scrolled enough up to realise that.

@uBlock-user
Copy link
Contributor

I have other extensions.

List them all individually @Mishasama

@gorhill
Copy link
Member

gorhill commented Jan 15, 2022

Closing as invalid due to failure to provide more information after asked to list all extensions and provide actual evidence with screenshots.

uBO does not touch that webrtc setting, hence unless magic is involved, the issue can't be uBO. Best explanation is that OP had another webrtc-controlling extension installed -- possibly dlinbernard/webrtc-control#3.

@gorhill gorhill closed this as completed Jan 15, 2022
@gorhill gorhill added invalid not a uBlock issue and removed unable to reproduce cannot reproduce the issue labels Jan 15, 2022
@Mishasama
Copy link
Author

Mishasama commented Jan 15, 2022

Sorry too busy for the late reply.

I think this should not be related to Chrome itself.
Because I didn't update or modify Chrome at all. It just happens after the extensions updates.

@gorhill
Copy link
Member

gorhill commented Jan 15, 2022

As said, file an issue with Chromium devs, what you say is happening can't happen.

@gwarser
Copy link

gwarser commented Jan 15, 2022

Did you enabled everything in chrome://flags/???

I didn't update or modify Chrome at all.

Then your installation is broken. Or profile. Try creating new profile and test there.

@gorhill
Copy link
Member

gorhill commented Jan 15, 2022

Try creating new profile and test there.

See:

  • using a new, unmodified browser profile

@uBlock-user
Copy link
Contributor

@gorhill He has 3 WebRTC specific extensions installed - WebRTC Control, WebRTC Leak Prevent, WebRTC Protect IP Leak,

There's the cause of your issue @Mishasama

@u-RraaLL
Copy link
Contributor

He has 3 WebRTC specific extensions installed - WebRTC Control, WebRTC Leak Prevent, WebRTC Protect IP Leak,

Aren't they disabled?

@uBlock-user
Copy link
Contributor

uBlock-user commented Jan 16, 2022

He disabled them now, or were they disabled when the issue occurred ?

Given the amount of extensions he has installed, something like this is bound to occur.

@gorhill
Copy link
Member

gorhill commented Jan 16, 2022

From now on, the only way to report such issue without being immediately closed as invalid is to show that the code at this line is being executed by putting a breakpoint at that line and posting a screenshot of the breakpoint being taken. This can happen only on Firefox Mobile.

Aren't they disabled?

You can disable the extra extension after triggering the issue and take a screenshot of this to make it look like uBO caused this. Unless there is a bug in the JS engine, this is downright impossible uBO is touching that setting -- this occurs only when uBO detects it's running in Firefox (using a Firefox's only extension API) and checking for the string mobile in the user agent.

@gorhill
Copy link
Member

gorhill commented Feb 5, 2022

There has been new development on this curious issue: https://www.reddit.com/r/uBlockOrigin/comments/sl7p74/disabling_webrtc/hvptao8/. It appears the browser is caching the information that an extension is toggling on a setting and reused that cached information to make the assumption that the setting is still toggled by the extension despite not being the case. There is a workaround for this, which is to make an explicit API call to make clear that uBO is not using the API. This will be in next release.

gorhill added a commit to gorhill/uBlock that referenced this issue Feb 5, 2022
@uBlock-user uBlock-user added the external issue involving an external factor label Feb 5, 2022
@gorhill gorhill removed the invalid not a uBlock issue label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external issue involving an external factor
Projects
None yet
Development

No branches or pull requests

5 participants