Unexplained popup block on streamlare #1912

ghajini · 2021-12-31T06:44:28Z

Prerequisites

I verified that this is not a filter issue (MUST be reported at filter issue tracker)
This is not a support issue or a question
I performed a cursory search of the issue tracker to avoid opening a duplicate issue
The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
I checked the documentation to understand that the issue I report is not a normal behavior

I tried to reproduce the issue when...

uBO is the only extension
uBO with default lists/settings
using a new, unmodified browser profile

Description

Download is inaccurately closed by popup filter

A specific URL where the issue occurs

https://streamlare.com/v/RWwM7lM8ZPPzZKbo

Steps to Reproduce

Go to https://atishmkv.fun/antim-the-final-truth-2021-zee5-web-dl-hindi-dd2-0-1080p-720p-480p/?player=2
click on in video download button that is their in video player like

https://user-images.githubusercontent.com/886325/147819078-d22e0519-1891-47aa-bfcd-075eb33f06b0.png

a new tab is opened of streamlare.com
click on download > original
whole new tab alongwith download request is closed by *$popup,3p,domain=streamlare.com which should not happen

issue is not reproducible when directly visiting https://streamlare.com/v/RWwM7lM8ZPPzZKbo and clicking download

Expected behavior

download should happen and not to be closed by popup filter

Actual behavior

download request is cancelled by popup filter

Screenshot

uBlock Origin version

1.40.2

Browser name and version

firefox android 95.2.0

Operating System and version

android 11

Notes=

Issue is not their in other adblockers

The text was updated successfully, but these errors were encountered:

gwarser · 2021-12-31T10:46:18Z

click on inline video download button that is their in video player

... ? 🤔

🤦

I can reproduce now easily. You have to click this button:

I did not even seen it before.

I was trying all other buttons, but not this one...

Even streamlare popup after clicking this button is blocked sometimes for me.

Now I see why context is 3,3 - because player is inside iframe. Also there is no link with href - popup is opened by script - this explains why it's closed by uBO.

It was discussed in this thread: https://listauthorschat.slack.com/archives/C010N14G4TF/p1640794269041100?thread_ts=1640788146.040900&cid=C010N14G4TF

gwarser · 2021-12-31T11:17:57Z

ABP/AdBlock:
I need to click few times on player to activate and then few times on download button on streamlare
AdGuard:
I need to click few times on player but download on streamlare starts on first click
uBO:
Player is activated on first click. Clicking on download button as soon as possible closes the tab and prevents download. If I wait 10s on streamlare and then click on download, then it works on first click.

gorhill · 2021-12-31T12:14:40Z

The screenshot shows uBO is acting as per EasyList's *$popup,3p,domain=streamlare.com filter.

What is the issue?

mapx- · 2021-12-31T13:16:33Z

see the steps above:

issue is not reproducible when directly visiting https://streamlare.com/v/RWwM7lM8ZPPzZKbo and clicking download

gorhill · 2021-12-31T13:28:19Z

When I navigate to https://streamlare.com/v/RWwM7lM8ZPPzZKbo and click the download button, a new tab to streamlare.com opens. This tab is not closed on my side, it does not match *$popup,3p,domain=streamlare.com.

ghajini · 2021-12-31T16:40:27Z

@gorhill you don't have to go to streamlare website directly, you visit
first https://atishmkv.fun/antim-the-final-truth-2021-zee5-web-dl-hindi-dd2-0-1080p-720p-480p/?player=2

then click play and click on download like pointed out https://user-images.githubusercontent.com/886325/147819078-d22e0519-1891-47aa-bfcd-075eb33f06b0.png
click on download button then download request is closed

as like i captured video here
https://gofile.io/d/vWDL1V

gorhill · 2021-12-31T17:41:31Z

Your captured video does not work, the site is telling me it does not have the bandwidth. In any case, I am not able to reproduce anything unexpected, I get exactly what I see in your screenshot.

If I exclude larecontent.com as a popup, I can download:

*$popup,3p,denyallow=larecontent.com,domain=streamlare.com
*$popup,3p,domain=streamlare.com,badfilter

Why do you think it's a uBO issue? This appears to be just a filter issue.

ghajini · 2021-12-31T18:03:34Z

where can i upload the video to view for you ?
i just explained pretty simple in STR
its not filter issue @gwarser can you explain pls

gwarser · 2021-12-31T18:13:38Z

It's about difference between popup handling in uBO and other blockers as listed above.

Your not detailed enough STR @ghajini did not helped.

Going directly to streamlare or clicking download links on atishmkv:

does not cause this popup to be closed. Only clicking download button inside the player causes popup to be closed.

I spent too much time trying to figure out what is happening. Thought this is some racing issue in popup filtering code. Only after reading STR in this issue I was able to reproduce popup being actually closed.

I will move this to uAssets to be fixed in filters.

ghajini · 2021-12-31T18:18:30Z

i know STR language somewhat difficult written...

But basic behaviour should be actually same across all adblockers(eg try with adguard)

gorhill · 2021-12-31T18:19:37Z

But basic behaviour should be actually same across all adblockers

And why assume uBO is wrong? If the other blockers do not trigger on *$popup,3p,domain=streamlare.com, does that mean they would not close actual malicious popups as well?

ghajini · 2021-12-31T18:24:33Z

@gorhill before 10 seconds popup filter *$popup,3p,domain=streamlare.com is triggered and closes the tab

after 10 seconds i can download the video normally
would you please?

gwarser · 2021-12-31T18:25:23Z

I noted some thoughts in https://listauthorschat.slack.com/archives/C010N14G4TF/p1640794269041100?thread_ts=1640788146.040900&cid=C010N14G4TF

The download button href is correct - should uBO close popup afer user-initiated click on "Original" download button on streamlare? Even if this is after scripted popup from player inside atishmkv.

ghajini · 2021-12-31T18:37:53Z

i first reported in 2019 also uBlockOrigin/uAssets#5374 (comment)
(site is dead btw)

gorhill · 2021-12-31T18:43:22Z

Ok I finally get it now. I need to investigate whether uBO can distinguish actual popups versus download requests.

gorhill · 2021-12-31T19:03:19Z

Sorry about being hard headed, I was blinded by the fact that all seemed fine in the logger output.

The issue is that the new tab opened, https://streamlare.com/v/RWwM7lM8ZPPzZKbo, is in popup-candidate status for at least 10s (the 10s which is a mitigation for others cases, this won't change). So for 10s, any navigation away from the original https://streamlare.com/v/RWwM7lM8ZPPzZKbo is going to cause a test against popup filters. The download operation causes a document to be created for the current tab, and since the URL of the download is 3p to streamlare.com, it causes the tab to close.

The difficulty is that browser's webRequest.onBeforeRequest API does not distinguish between document fetched for download purpose or fetched for tab purpose -- and thus uBO treats the downloaded resources as any other document. Not sure how this is best solved with minimal amount of code changes, the popup blocking code has become complex over the years to solve all sort of reported issues.

Note that the fact the other blockers not being triggered could simply mean they are vulnerable to popups which are triggered a few seconds after navigation, this would have to be tested on their side.

Related issue: - uBlockOrigin/uBlock-issues#1912 Related commit: - 7713597 In above related commit, uBO was modified to cache the URL of the last clicked link, and to use this cached URL to test for the legitimacy of the newly opened tab. The current commit add back a test against the URL of the last clicked link to avoid false positives when navigating from within the newly opened tab.

ghajini · 2022-02-06T08:09:09Z

This is happening again ie download request is closed by popup filter within 10 sec
ublock origin dev, google chrome Version 98.0.4758.81 (Official Build) (64-bit)

STR=

first add streamlare.com#@#+js(aopr, open) { this filter blocks new tab of streamlare as well as popups}
navigate to https://atishmkv.life/antim-the-final-truth-2021-zee5-web-dl-hindi-dd2-0-1080p-720p-480p/
click server 2 ultrafast
now click this download button

this will open new tab of https://streamlare.com/e/RWwM7lM8ZPPzZKbo

5.now click download > original within 10 sec interval
download request is closed by popup filter from easylist *$popup,3p,domain=streamlare.com

Expected behaviour= able to download the file

Actual behaviour= not able to download the file

gwarser · 2022-02-06T20:35:00Z

Second player does not load.

ghajini · 2022-02-07T05:05:24Z

On my side it loads, you need to click server 2 ultrafast> click to play

uBlock-user · 2022-02-07T06:16:04Z

Never loads for me either.

ghajini · 2022-02-07T07:10:38Z

ok although player loads on my side, you load this website
https://w-123movies.com/episodes/power-book-iv-force-x9NLdw-season-1-episode-1/
click streamlare server from servers list, (Steps to reproduce is same)

screenvideo=https://gofile.io/d/AnV2oN

gwarser · 2022-02-07T10:44:53Z

Still does not load, but works if I open https://streamlare.com/e/b8K02DP6NK6lygB1 directly.

Looks like clicking on the "Original" button opens about:blank tab and then redirects to final download URL.

gwarser · 2022-02-07T11:05:33Z

@@||ssl0d.com^$popup,domain=streamlare.com

gwarser · 2022-02-07T11:12:50Z

Looks like clicking on the "Original" button opens about:blank tab and then redirects to final download URL.

It does not now. Hmmm...

ghajini · 2022-02-07T14:13:30Z

@@||ssl0d.com^$popup,domain=streamlare.com

that is workaround ,i can even badfilter easylist filter,but that's not the point here....the domain you pointed was different days ago and it will change henceforth again...can we get fix?

gwarser · 2022-02-07T14:48:01Z

ABP does not even opent the download page after clicking the button in player ui.

Add-ons handle popup option differently. That is how it is.

ghajini · 2022-02-07T15:22:11Z

i never use ABP, will you try adguard browser extension?

gwarser · 2022-02-07T16:30:05Z

@gorhill can this 10s timeout be reset when user interacts with the page?

gwarser · 2022-02-07T16:38:22Z

Actually - I did not even checked if it's even the case of delayed detection. Source page is streamlare.com, and popup ssl0d.com (or smth.) processed by global click event. @ghajini does it work if you wait in this case too? I cannot reproduce anymore - someone added exception?

No popup is detected anymore.

gorhill · 2022-02-07T16:44:37Z

If we keep loosening the heuristic, it's a matter of time before someone report that now there are unwanted popups as a result of loosened heuristic, which came about after years of repeated fine tuning.

From what I see, the clicked link navigate to www-0r.ssl0d.com, which responds with a 301 redirect to www-uck50271.ssl0d.com, so as far as uBO is concerned, the ultimate navigation target does not match the clicked link, and this is deemed an unwanted popup, as per EasyList's *$popup,3p,domain=streamlare.com.

Maybe uBO should take into account the response header content-disposition as a hint that we are not dealing with a popup.

ghajini · 2022-02-07T17:54:50Z

@gwarser after 10 sec, popup filter doesn't match and i can download the file

gwarser changed the title ~~bug~~ Unexplained popup block on streamlare Dec 31, 2021

gwarser closed this as completed Dec 31, 2021

gwarser reopened this Dec 31, 2021

gwarser transferred this issue from another repository Dec 31, 2021

gorhill transferred this issue from uBlockOrigin/uAssets Dec 31, 2021

uBlock-user added bug Something isn't working fixed issue has been addressed labels Jan 1, 2022

uBlock-user closed this as completed Jan 1, 2022

ghajini mentioned this issue Feb 5, 2022

streamlare.com: nuisance uBlockOrigin/uAssets#11485

Closed

8 tasks

uBlockOrigin deleted a comment Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unexplained popup block on streamlare #1912

Unexplained popup block on streamlare #1912

ghajini commented Dec 31, 2021

gwarser commented Dec 31, 2021 •

edited

Loading

gwarser commented Dec 31, 2021

gorhill commented Dec 31, 2021

mapx- commented Dec 31, 2021 •

edited

Loading

gorhill commented Dec 31, 2021 •

edited

Loading

ghajini commented Dec 31, 2021 •

edited

Loading

gorhill commented Dec 31, 2021 •

edited

Loading

ghajini commented Dec 31, 2021 •

edited

Loading

gwarser commented Dec 31, 2021

ghajini commented Dec 31, 2021

gorhill commented Dec 31, 2021

ghajini commented Dec 31, 2021

gwarser commented Dec 31, 2021

ghajini commented Dec 31, 2021

gorhill commented Dec 31, 2021

gorhill commented Dec 31, 2021 •

edited

Loading

ghajini commented Feb 6, 2022 •

edited

Loading

gwarser commented Feb 6, 2022

ghajini commented Feb 7, 2022

uBlock-user commented Feb 7, 2022

ghajini commented Feb 7, 2022 •

edited

Loading

gwarser commented Feb 7, 2022

gwarser commented Feb 7, 2022

gwarser commented Feb 7, 2022

ghajini commented Feb 7, 2022

gwarser commented Feb 7, 2022 •

edited

Loading

ghajini commented Feb 7, 2022

gwarser commented Feb 7, 2022

gwarser commented Feb 7, 2022 •

edited

Loading

gorhill commented Feb 7, 2022

ghajini commented Feb 7, 2022

Unexplained popup block on streamlare #1912

Unexplained popup block on streamlare #1912

Comments

ghajini commented Dec 31, 2021

Prerequisites

I tried to reproduce the issue when...

Description

A specific URL where the issue occurs

Steps to Reproduce

Expected behavior

Actual behavior

Screenshot

uBlock Origin version

Browser name and version

Operating System and version

Notes=

gwarser commented Dec 31, 2021 • edited Loading

🤦

gwarser commented Dec 31, 2021

gorhill commented Dec 31, 2021

mapx- commented Dec 31, 2021 • edited Loading

gorhill commented Dec 31, 2021 • edited Loading

ghajini commented Dec 31, 2021 • edited Loading

gorhill commented Dec 31, 2021 • edited Loading

ghajini commented Dec 31, 2021 • edited Loading

gwarser commented Dec 31, 2021

ghajini commented Dec 31, 2021

gorhill commented Dec 31, 2021

ghajini commented Dec 31, 2021

gwarser commented Dec 31, 2021

ghajini commented Dec 31, 2021

gorhill commented Dec 31, 2021

gorhill commented Dec 31, 2021 • edited Loading

ghajini commented Feb 6, 2022 • edited Loading

gwarser commented Feb 6, 2022

ghajini commented Feb 7, 2022

uBlock-user commented Feb 7, 2022

ghajini commented Feb 7, 2022 • edited Loading

gwarser commented Feb 7, 2022

gwarser commented Feb 7, 2022

gwarser commented Feb 7, 2022

ghajini commented Feb 7, 2022

gwarser commented Feb 7, 2022 • edited Loading

ghajini commented Feb 7, 2022

gwarser commented Feb 7, 2022

gwarser commented Feb 7, 2022 • edited Loading

gorhill commented Feb 7, 2022

ghajini commented Feb 7, 2022

gwarser commented Dec 31, 2021 •

edited

Loading

mapx- commented Dec 31, 2021 •

edited

Loading

gorhill commented Dec 31, 2021 •

edited

Loading

ghajini commented Dec 31, 2021 •

edited

Loading

gorhill commented Dec 31, 2021 •

edited

Loading

ghajini commented Dec 31, 2021 •

edited

Loading

gorhill commented Dec 31, 2021 •

edited

Loading

ghajini commented Feb 6, 2022 •

edited

Loading

ghajini commented Feb 7, 2022 •

edited

Loading

gwarser commented Feb 7, 2022 •

edited

Loading

gwarser commented Feb 7, 2022 •

edited

Loading