Permit arbitrary quantity of lines to be fed into Recurrence Tests #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the test framework in `RecurrenceTests.php` permit three ical lines to be passed when creating a `VEVENT` to test. (Expected to be `DTSTART`, `DTEND`, and `RRULE`) Some tests only use two lines (typically skipping `DTEND`); whilst it would also be nice to be pass more lines, so as to build tests with arbitrary quantities of `EXDATE`s, `RDATE`s, etc. The `rfc5545RecurrenceExamplesTest.php` file already uses this same methodology to permit more than three lines to be added to a test `VEVENT`.
s0600204
changed the title
u01jmg3
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the test framework in
RecurrenceTests.phppermit three ical lines to be passed when creating aVEVENTto test. (Expected to beDTSTART,DTEND, andRRULE)Some tests only use two lines (typically skipping
DTEND), whilst it would also be nice to be pass more lines, so as to build tests with arbitrary quantities ofEXDATEs,RDATEs, etc.The
rfc5545RecurrenceExamplesTest.phpfile already uses this methodology to permit more than three lines to be added to a testVEVENT.PR created primarily to circumvent whitespace problem with PR #246.