fix command names being invalid package names #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangecms
force-pushed
the
main
branch
2 times, most recently
from
5b705ad to
d056583
Compare
hugelgupf
reviewed
Sep 23, 2020
hugelgupf
reviewed
Sep 23, 2020
orangecms
force-pushed
the
main
branch
4 times, most recently
from
c5889ec to
7354ebc
Compare
This may potentially allow for collisions again, because valid identifiers allow for less characters than valid commands names. Also add a test case for a "fancy" cmd name. This command name intentionally starts with digits and contains characters not valid in identifiers (`-`). Signed-off-by: Daniel Maslowski <[email protected]>
hugelgupf
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to resolve #41 :)