-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only allow builds when go build
also works
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Koch <[email protected]>
hugelgupf
force-pushed
the
mod
branch
17 times, most recently
from
February 24, 2024 23:00
d42e6f7
to
a2a7206
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
hugelgupf
force-pushed
the
mod
branch
3 times, most recently
from
February 24, 2024 23:26
0570188
to
f9aadc4
Compare
Now that findpkg has dropped support for finding packages that are not also found by `go list`, we can simplify busybox module resolution as well. To support workspaces, modules, and no-module compilation, we query `go list` for all dependencies, write them to the temporary directory, and build with `GO111MODULE=off`. This means we will always support offline compilation (E.g. a vendored workspace or a vendored module will remain offline.) Signed-off-by: Chris Koch <[email protected]>
hugelgupf
changed the title
gobb: only build when
Only allow builds when Feb 24, 2024
go build
also worksgo build
also works
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Go workspaces, including vendored workspaces, as well as support for offline builds in all cases -- vendored workspaces, vendored command modules, and GOPATH.
This removes support for "synthesized" go.mod files, in which stuff like
used to work. In the same situation,
go build ./u-root/cmds/core/init ./cpu/cmds/cpud
would not have worked.go build
doesn't work in the same situation. We now require thatgo build
work.For the same situation, Go workspaces exist:
For more information, read the new README.
Closes #109
Closes #35
Closes #64
Closes #24
Closes #14
Closes #8
Updates #104.