Package #73
Closed
Package #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HostName is either the Host, or the HostName as found in an .ssh/config file. Use HostName for the Dial, not Host. Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
We should not determine the rules of a valid port type in this package; that's up to the net package. Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
This will, gradually, become equivalent to, and replace, the old one that did not use the package. Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
This works to this point: ./cpu -old=false v mount 2022/03/09 14:57:14 c.Run: (<nil>, "rootfs on / type rootfs (rw)\nproc on /proc type proc (rw,relatime)\nsysfs on /sys type sysfs (rw,relatime)\nfusectl on /sys/fs/fuse/connections type fusectl (rw,relatime)\ndevpts on /dev/pts type devpts (rw,relatime,mode=600,ptmxmode=000)\ntmpfs on /dev/shm type tmpfs (rw,relatime)\ncpu on /tmp type tmpfs (rw,relatime)\n127.0.0.1 on /tmp/cpu type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\nrootfs on /tmp/local type rootfs (rw)\n127.0.0.1 on /lib type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\n127.0.0.1 on /lib64 type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\n127.0.0.1 on /usr type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\n127.0.0.1 on /bin type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\n127.0.0.1 on /etc type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\n127.0.0.1 on /home type 9p (rw,nosuid,nodev,relatime,sync,dirsync,uname=rminnich,access=client,msize=1048576,trans=fd,rfd=9,wfd=9)\n", "") Note that the namespace worked fine, using the package code. Signed-off-by: Ronald G. Minnich <[email protected]>
|
What does pkg/package mean here? I am not seeing it. 🤔 Is that about the |
The culture has changed. pkg is no longer the standard. Packages start at top level now. and you're supposed to use internal/ where possible to hide packages you don't want people to see for but cpu/cpu is still a package :-) |
|
anyway it's not ready, this will be a series, almost there but not quite |
There was an interesting gotcha with this line:
c.Env = append(c.Env, "CPUNONCE="+c.nonce.String())
when the nonce was not set, it seemed to create a corrupt environment,
and the cmd.Start would return EINVAL.
Kernels that use integer error return should not be allowed to exist.
But they do, sadly.
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Signed-off-by: Ronald G. Minnich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.