Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary disambiguation around ibids #250

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MaxGietl
Copy link
Contributor

Fixes #129.

Disambiguation currently compares the normal render of a citation. This means that if two different citations both render to "ibid", they are disambiguated without actually being ambiguous. This PR solves that by creating a second render that disables ibids and using that for comparison.

Example:

First mention of Smith @smith[1].
Second mention of Smith @smith[2].

First mention of Mayer @mayer[1].
Second mention of Mayer @mayer[2].

Hayagriva disambiguates the citations, even though they aren't ambigous. 

#bibliography("bibliography.yaml", style: "deutsche-sprache")

bibliography.yaml

smith:
  type: article
  title: First article of Smith
  author: Smith
  date: 1990

mayer:
  type: article
  title: Article of Mayer
  author: Mayer
  date: 2010

Faulty render without this PR
Screenshot 2024-11-20 154755

Correct render with this PR
image

@MaxGietl
Copy link
Contributor Author

These tests also fail on main currently, so I think this has nothing to do with my changes?

@MaxGietl
Copy link
Contributor Author

@tsteckenborn Could you confirm this also fixes your issue or could you provide the files that caused this for you?

@PgBiel
Copy link
Contributor

PgBiel commented Nov 20, 2024

These tests also fail on main currently, so I think this has nothing to do with my changes?

Are you sure? I'd expect archive tests to fail as archive tests just compare the existing archive files with upstream CSL styles, but no citeproc tests are failing on main (at least, the CI check is green). Your PR might have triggered some unintended side-effects (would need further investigation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issues with disambiguation?
2 participants