Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [email protected] typings #291

Closed
wants to merge 1 commit into from
Closed

Add [email protected] typings #291

wants to merge 1 commit into from

Conversation

unindented
Copy link

@blakeembrey
Copy link
Member

@unindented Are you a maintainer of normalizr? Would you be interested in keeping the type definitions inside the repo itself instead? Doing that would provide immediate value for TypeScript users instead of making them use Typings.

@unindented
Copy link
Author

@blakeembrey You are right, that's the better option. Adding a typings field to the package.json that points to the .d.ts file would be enough, right?

@unindented unindented closed this Apr 5, 2016
@blakeembrey
Copy link
Member

Yes, that's all you need to do and TypeScript users will appreciate it 😄

@blakeembrey
Copy link
Member

You're welcome to ping me too, if you need a definition review.

@unindented
Copy link
Author

@blakeembrey I've created a PR, if you have the time to review: paularmstrong/normalizr#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants