Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ssl_cacert from return codes #158

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Remove ssl_cacert from return codes #158

merged 1 commit into from
Oct 3, 2019

Conversation

arku
Copy link
Contributor

@arku arku commented Oct 3, 2019

Fixes #157

/cc @PericlesTheo

@PericlesTheo
Copy link
Member

Hey @arku, thanks for your work. Could you rebase with master? The build was broken when you checked out. Once you do and in theory the CI passes, I will merge the PR

@arku
Copy link
Contributor Author

arku commented Oct 3, 2019

@PericlesTheo Done!

Thanks for the review 🙂

@andremedeiros
Copy link
Member

@arku well done, thank you for tackling this one! 🎉

@PericlesTheo PericlesTheo merged commit 8f9c711 into typhoeus:master Oct 3, 2019
@arku arku deleted the chore/ssl_cacert-removal branch October 5, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andremedeiros andremedeiros andremedeiros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate error code 51
3 participants
@arku @PericlesTheo @andremedeiros