Annotate some UI classes for nullness #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: * DefaultListCellRenderer * DefaultTableCellRenderer * DefaultTreeCellRender * the classes that they call to get possibly null values
jpschewe
changed the title
|
@mernst |
The way that the cache is setup in Locale, get cannot return null since createObject cannot return null and null keys are not allowed.
It's an internal sun class and shouldn't be used outside. I had started annotating it to help with the annotations for Locale and realized that this was a mistake.
jpschewe
changed the title
|
The build is failing only because of the changes in |
These changes have been moved to PR typetools#89.
mernst
reviewed
Sep 29, 2020
mernst
reviewed
Sep 29, 2020
| @@ -532,7 +533,7 @@ public void setSelectedFile(File file) { | |||
| */ | |||
| @BeanProperty(description | |||
| = "The list of selected files if the chooser is in multiple selection mode.") | |||
| public void setSelectedFiles(File[] selectedFiles) { | |||
| public void setSelectedFiles(@Nullable File[] selectedFiles) { | |||
There was a problem hiding this comment.
Here, too, @Nullable should be on the array type.
There was a problem hiding this comment.
Here the array itself can be null, so I've pushed a fix for this.
The elements of the array "may" be null, but probably shouldn't be null.
mernst
reviewed
Sep 29, 2020
| private File[] selectedFiles; | ||
| private @Nullable File currentDirectory = null; | ||
| private @Nullable File selectedFile = null; | ||
| private @Nullable File[] selectedFiles; |
There was a problem hiding this comment.
Based on the code, I believe this should be File @Nullable [] (a possibly-null array of non-null files) rather than @Nullable File[] (a non-null array of possibly-null files).
There was a problem hiding this comment.
Agreed, pending the comment above about possibly allowing nulls inside the array.
mernst
requested changes
Sep 29, 2020
mernst
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of classes annotated for nullness: