Rename TypeHierarchy#isSubtype to TypeHierarchy#isSubtypeOrConvertible #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of renaming the method, I'll document which conversion are performed by isSubtype and how they are preformed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeHierarchy#isSubtype(AnnotatedTypeMirror, AnnotatedTypeMirror)is implemented to accept combinations of AnntotatedTypeMirrors where the underlying Java types are not subtypes, but are convertible. For example AnnotatedDeclaredType, AnnotatedPrimitiveType, see implementation here. So the name should really be isSubtypeOrConvertible.It would make the transition easier if isSubtype could be deprecated, but because TypeHierarchy is an interface, then all implementations would have to implement both isSubtype and isSubtypeOrConvertible. And then once isSubtype is removed, the implementations would have to change again. It's really a question of whether we think more clients call TypeHierarchy#isSubtype than implement TypeHierarchy. I would appreciate input on this.
Most of the changes are from automatic refactoring. I also improved the Javadoc on isSutypeOrConvertible, which should be reviewed more carefully than the other changes.