Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExtendedNode and Label public again #6130

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Make ExtendedNode and Label public again #6130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d8c38
Make ExtendedNode and Label public again
msridhar Aug 12, 2023
a82bbf5
add comment
msridhar Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/ExtendedNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@
* <li><em>TWO_TARGET_CONDITIONAL_JUMP</em>: {@link ConditionalJump}. A conditional jump with two
* targets for both the 'then' and 'else' branch.
* </ul>
*
* Note that this class is deliberately public, to enable users of the dataflow library to customize
* CFG construction.
*/
@SuppressWarnings("nullness") // TODO
/*package-private*/ abstract class ExtendedNode {
abstract class ExtendedNode {

/** The basic block this extended node belongs to (as determined in phase two). */
protected BlockImpl block;
Expand Down
5 changes: 4 additions & 1 deletion dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/Label.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@
* A label is used to refer to other extended nodes using a mapping from labels to extended nodes.
* Labels get their names either from labeled statements in the source code or from internally
* generated unique names.
*
* <p>Note that this class is deliberately public, to enable users of the dataflow library to
* customize CFG construction.
*/
/*package-private*/ class Label {
class Label {

/** Unique id counter that incremented in {@code #uniqueName}. */
private static int uid = 0;
Expand Down