Remove google-libphonenumber and migrate to jest/eslint #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced mocha, chai, sinon and nyc with jest Refactored tests to use jest Removed google-libphonenumber Removed gulp and associated dependencies Replaced gulp with npm scripts (copyfiles, json, rimraf) Updated all dependencies
|
Hi @rmuchall. Thank you for creating this PR! Unfortunately we have one big PR in review (#568) and we have to wait until merge. But after merging I am open check this PR. For now just few comments from my side:
|
|
Hi @vlapo, |
|
Hi @vlapo |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Following my PR to routing-controllers (typestack/routing-controllers#553) I'm now submitting a similar PR for class-validator.
Action taken
Removed google-libphonenumber
Reasoning
google-libphonenumber is huge. Although a work-around exists I believe the better option is to remove it. See (#248)
Action taken
Replaced mocha, chai, sinon and nyc with jest
Reasoning
To normalize the test framework across all my projects
Jest appears to be a more complete framework
Jest is more popular
https://npmcompare.com/compare/jest,mocha
Action taken
Replaced gulp with npm scripts (copyfiles, json, rimraf)
Reasoning
Gulp is awesome but we can achieve the same result by using npm scripts (same as routing-controllers)
Action taken
Replaced tslint with eslint
Reasoning
tslint is deprecated and the recommended replacement is eslint
Other changes
Updated all dependencies
Thanks,
Rob