Fix version date calculation in corner cases #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename `date` argument to `today`. * Cache `last_date` and add an explaining comment.
Previously, if the latest published stub version was higher than the upstream version (which could happen with our old versioning scheme), we always used the current date as last component. This failed when uploading the same package twice in a day – but also in our stub_uploader tests, which simulate a new upload.
|
Best reviewed commit by commit. |
This was referenced Oct 19, 2024
|
|
||
| # Make sure that the last published release is not unreasonable large. | ||
| assert int(date.strftime("%Y%m%d")) + 14 > max_published.release[-1] | ||
| assert int(today.strftime("%Y%m%d")) + 14 > last_date |
There was a problem hiding this comment.
Where does 14 come from here? Is it just arbitrary?
There was a problem hiding this comment.
Yes. It's very unlikely we publish more than 14 versions in a day.
There was a problem hiding this comment.
While 13 versions are just a little unlikely, I guess :)
There was a problem hiding this comment.
While 13 versions are just a little unlikely, I guess :)
a little unlikely, but very unlucky
JelleZijlstra
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the latest published stub version was higher
than the upstream version (which could happen with our old
versioning scheme), we always used the current date as
last component. This failed when uploading the same package
twice in a day – but also in our stub_uploader tests, which
simulate a new upload.