fix: don't trigger error on empty Source Definition response (#568)

typescript-language-server · Aug 21, 2022 · 146a6ba · 146a6ba
1 parent 195595d
commit 146a6ba
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/features/source-definition.ts b/src/features/source-definition.ts
@@ -60,10 +60,11 @@ export class SourceDefinitionCommand {
             reporter,
         }, async () => {
             const response = await tspClient.request(CommandTypes.FindSourceDefinition, args);
-            if (response.type === 'response' && response.body?.length) {
-                return response.body.map(reference => toLocation(reference, documents));
+            if (response.type !== 'response' || !response.body) {
+                lspClient.showErrorMessage('No source definitions found.');
+                return;
             }
-            lspClient.showErrorMessage('No source definitions found.');
+            return response.body.map(reference => toLocation(reference, documents));
         });
     }
 }