-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-unnecessary-condition] properly reflect multiple negations in message #9940
fix(eslint-plugin): [no-unnecessary-condition] properly reflect multiple negations in message #9940
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 493870e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9940 +/- ##
==========================================
+ Coverage 86.00% 88.69% +2.68%
==========================================
Files 425 425
Lines 14810 14811 +1
Branches 4308 4309 +1
==========================================
+ Hits 12738 13136 +398
+ Misses 1723 1531 -192
+ Partials 349 144 -205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…o-unnecessary-condition-multinegation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 ✨
77e65df
into
typescript-eslint:main
PR Checklist
Overview
Properly reflect the truthiness or falsiness of a value after multiple negations, and expand the reporting range to include the negation operator(s).