Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-condition] properly reflect multiple negations in message #9940

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Sep 5, 2024

PR Checklist

Overview

Properly reflect the truthiness or falsiness of a value after multiple negations, and expand the reporting range to include the negation operator(s).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 493870e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66e03574535e2b000856809f
😎 Deploy Preview https://deploy-preview-9940--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Sep 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 493870e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (4d31ebe) to head (493870e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9940      +/-   ##
==========================================
+ Coverage   86.00%   88.69%   +2.68%     
==========================================
  Files         425      425              
  Lines       14810    14811       +1     
  Branches     4308     4309       +1     
==========================================
+ Hits        12738    13136     +398     
+ Misses       1723     1531     -192     
+ Partials      349      144     -205     
Flag Coverage Δ
unittest 88.69% <100.00%> (+2.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 99.04% <100.00%> (+0.48%) ⬆️

... and 103 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 ✨

@JoshuaKGoldberg JoshuaKGoldberg merged commit 77e65df into typescript-eslint:main Sep 13, 2024
64 of 65 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-condition] rule message is incorrect for multiple negations
2 participants